From: Kamil Konieczny Subject: Re: [PATCH] crypto: mxs-dcp: Add empty hash export and import Date: Tue, 16 Jan 2018 18:33:14 +0100 Message-ID: <08646712-9fc0-4f61-3f3d-31fc7cb6cf90@partner.samsung.com> References: <4f3389a1-d6aa-b3cc-2299-d638058ddd48@partner.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Bartlomiej Zolnierkiewicz , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org To: Marek Vasut , Herbert Xu Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:48748 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbeAPRdV (ORCPT ); Tue, 16 Jan 2018 12:33:21 -0500 In-reply-to: Content-language: en-US Sender: linux-crypto-owner@vger.kernel.org List-ID: On 16.01.2018 17:56, Marek Vasut wrote: > On 01/16/2018 05:16 PM, Kamil Konieczny wrote: >> Crypto framework will require async hash export/import, so add empty >> functions to prevent OOPS. > > Shouldn't this be handled on the subsystem level with some > > if (foo->bar) > foo->bar(); > > instead? I am sorry, I should write more elaborate description for patch. It is handled by subsystem. Most drivers have them, and testmgr is testing for export/import and drivers without them fail internal crypto tests, so I prepared patch which removed these two wrappers from crypto framework. In summary: export/import are now required, so crypto framework can work properly. -- Best regards, Kamil Konieczny Samsung R&D Institute Poland