From: Gilad Ben-Yossef Subject: Re: [PATCH 1/7] staging: ccree: remove ccree from staging tree Date: Thu, 18 Jan 2018 10:39:11 +0200 Message-ID: References: <1515662239-1714-1-git-send-email-gilad@benyossef.com> <1515662239-1714-2-git-send-email-gilad@benyossef.com> <20180113132100.GC17515@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: devel@driverdev.osuosl.org, Herbert Xu , Linux kernel mailing list , Linux Crypto Mailing List , "David S. Miller" , Ofir Drang To: Greg Kroah-Hartman Return-path: In-Reply-To: <20180113132100.GC17515@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: linux-crypto.vger.kernel.org On Sat, Jan 13, 2018 at 3:21 PM, Greg Kroah-Hartman wrote: > On Thu, Jan 11, 2018 at 09:17:08AM +0000, Gilad Ben-Yossef wrote: >> Remove the ccree driver from the staging tree in preparation to >> introducing it in the crypto tree. >> >> Signed-off-by: Gilad Ben-Yossef > > Heh, no, just make a patch series that adds the driver to the correct > location in the crypto tree. > > If that gets accepted, we can then delete the staging driver with a > separate patch, after the fact. No need for it to be in this patch > series. Yes, I should have been more communicative as to why I am doing this, sorry. The problem is that if you apply the patch adding the driver to drivers/crypto/ the kernel no longer links due to symbol name collisions. If we really must avoid doing an "atomic" replacement I guess I can change the Kconfig name to ...CCREE_OLD or something although I would prefer not doing that so that people using the driver in staging/ don't need to change their kernel build configs when they are upgrading versions. Does that makes sense? Thanks, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru