From: Herbert Xu Subject: Re: [PATCH] crypto: picoxcell - Fix error handling in spacc_probe() Date: Fri, 26 Jan 2018 23:46:41 +0800 Message-ID: <20180126154641.GJ4002@gondor.apana.org.au> References: <1516398795-9018-1-git-send-email-khoroshilov@ispras.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: ldv-project@linuxtesting.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , linux-crypto@vger.kernel.org, Jamie Iles , "David S. Miller" , linux-arm-kernel@lists.infradead.org To: Alexey Khoroshilov Return-path: Content-Disposition: inline In-Reply-To: <1516398795-9018-1-git-send-email-khoroshilov@ispras.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-crypto.vger.kernel.org On Sat, Jan 20, 2018 at 12:53:15AM +0300, Alexey Khoroshilov wrote: > If clk_get() fails, device_remove_file() looks inappropriate. > > The error path, where all crypto_register fail, misses resource > deallocations. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt