From: Harsh Jain Subject: Re: [PATCH v2 0/4] crypto: AF_ALG AIO improvements Date: Wed, 7 Feb 2018 14:22:20 +0530 Message-ID: References: <2118226.LQArbCsRu5@tauon.chronox.de> <20180201102519.000044c1@huawei.com> <1842104.0gXuQuQB9D@positron.chronox.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Jonathan Cameron , Gilad Ben-Yossef , Linux Crypto Mailing List , linuxarm@huawei.com To: =?UTF-8?Q?Stephan_M=c3=bcller?= , Herbert Xu Return-path: Received: from stargate.chelsio.com ([12.32.117.8]:38636 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752829AbeBGIwn (ORCPT ); Wed, 7 Feb 2018 03:52:43 -0500 In-Reply-To: <1842104.0gXuQuQB9D@positron.chronox.de> Content-Language: en-US Sender: linux-crypto-owner@vger.kernel.org List-ID: On 07-02-2018 13:12, Stephan Müller wrote: > Hi Herbert, > > Herbert, the patch 1 is meant for stable. However, this patch as is > only applies to the new AF_ALG interface implementation. Though, > the issue goes back to the first implementation of AIO support. > Shall I try prepare a patch for the old AF_ALG implementation > as well? > > Changes from v1: > > * integrate the inline IV and locking patch into one patch set > > * reverse the order of lock context IV patch and inline IV patch -- > the reason is to allow the first patch to be back-ported to stable > > * mark the first patch (locking of the context IV) as applicable to > stable as there is an existing inconsistency which was demonstrated > by Harsh with the Chelsio driver vs the AES-NI driver > > * modify the inline IV patch to have proper unlocking of the mutex > in case of errors > > * prevent locking if no IV is defined by cipher > > * add a patch to allow crypto drivers to report whether they support > serialization -- in this case the locking in AF_ALG shall be > disabled > > * add a patch to inform the crypto drivers that their serialization > support should actually be enabled and used because AF_ALG does not > serialize the interdependent parallel AIO requests > > * streamline the code in patch 1 and 2 slightly > > I would like to ask the folks with real AIO hardware (Harsh, Jonathan) > to test the patches. Especially, is the locking patch should be tested > by Harsh as you have seen the issue with your hardware. Sure I will test the patch and let you know. > > Thanks. > > Stephan Mueller (4): > crypto: AF_ALG AIO - lock context IV > crypto: AF_ALG - inline IV support > crypto: AF_ALG - allow driver to serialize IV access > crypto: add CRYPTO_TFM_REQ_PARALLEL flag > > crypto/af_alg.c | 119 +++++++++++++++++++++++++++++++++++++++++++- > crypto/algif_aead.c | 86 +++++++++++++++++--------------- > crypto/algif_skcipher.c | 38 ++++++++++---- > include/crypto/if_alg.h | 37 ++++++++++++++ > include/linux/crypto.h | 16 ++++++ > include/uapi/linux/if_alg.h | 6 ++- > 6 files changed, 249 insertions(+), 53 deletions(-) >