From: Herbert Xu Subject: Re: [PATCH v3] crypto: s5p-sss.c: Fix kernel Oops in AES-ECB mode Date: Thu, 15 Feb 2018 23:53:13 +0800 Message-ID: <20180215155312.GR7352@gondor.apana.org.au> References: <77384548-9870-40b8-46fc-4bd62747efd6@partner.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Krzysztof Kozlowski , Vladimir Zapolskiy , "David S. Miller" , Anand Moon , Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org To: Kamil Konieczny Return-path: Content-Disposition: inline In-Reply-To: <77384548-9870-40b8-46fc-4bd62747efd6@partner.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Wed, Feb 07, 2018 at 04:52:09PM +0100, Kamil Konieczny wrote: > In AES-ECB mode crypt is done with key only, so any use of IV > can cause kernel Oops. Use IV only in AES-CBC and AES-CTR. > > Signed-off-by: Kamil Konieczny > Reported-by: Anand Moon > Reviewed-by: Krzysztof Kozlowski > Tested-by: Anand Moon > Cc: stable@vger.kernel.org # can be applied after commit 8f9702aad138 > > --- > version 3: > Change commit message: drop 'Fixes: 8f9702aad138' as the error was > introduced earlier. Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt