From: David Howells Subject: Re: [PATCH] X.509: unpack RSA signatureValue field from BIT STRING Date: Wed, 07 Mar 2018 15:44:14 +0000 Message-ID: <30085.1520437454@warthog.procyon.org.uk> References: <88da0c24-385c-64a9-6d56-36696d433bc7@maciej.szmigiero.name> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: dhowells@redhat.com, Herbert Xu , "David S. Miller" , Tom Lendacky , Gary Hook , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org To: "Maciej S. Szmigiero" Return-path: In-Reply-To: <88da0c24-385c-64a9-6d56-36696d433bc7@maciej.szmigiero.name> Content-ID: <30084.1520437454.1@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org Maciej S. Szmigiero wrote: > + if (!strcmp(ctx->cert->sig->pkey_algo, "rsa")) { I'm going to change this to '== 0' rather than '!'. David