From: Geert Uytterhoeven Subject: Re: [PATCH v2 06/21] fpga: Remove depends on HAS_DMA in case of platform dependency Date: Tue, 20 Mar 2018 11:04:09 +0100 Message-ID: References: <1521208314-4783-1-git-send-email-geert@linux-m68k.org> <1521208314-4783-7-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Ulf Hansson , Wolfram Sang , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ALSA Development Mailing List , Bjorn Andersson , Eric Anholt , netdev , MTD Maling List , Linux I2C , linux1394-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Christoph Hellwig , Stefan Wahren , Boris Brezillon , "James E . J . Bottomley" , Herbert Xu , scsi , Richard Weinberger , Jassi Brar , Marek Vasut , linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matias Bjorling Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-crypto.vger.kernel.org Hi Alan, On Mon, Mar 19, 2018 at 5:06 PM, Alan Tull wrote: > On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven > wrote: > This essentially removes this commit > > commit 1c8cb409491403036919dd1c6b45013dc8835a44 > Author: Sudip Mukherjee > Date: Wed Aug 3 13:45:46 2016 -0700 > > drivers/fpga/Kconfig: fix build failure > > While building m32r allmodconfig the build is failing with the error: > > ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined! > > Xilinx Zynq FPGA is using DMA but there was no dependency while > building. > > Link: http://lkml.kernel.org/r/1464346526-13913-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org > Signed-off-by: Sudip Mukherjee > Acked-by: Moritz Fischer > Cc: Alan Tull > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds Yes it does. The major change is that the first (core) series introduces all needed dummies to do successful compile-testing on NO_DMA=y platforms. >> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another >> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". >> In most cases this other symbol is an architecture or platform specific >> symbol, or PCI. >> >> Generic symbols and drivers without platform dependencies keep their >> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that >> cannot work anyway. >> >> This simplifies the dependencies, and allows to improve compile-testing. >> >> Signed-off-by: Geert Uytterhoeven >> Reviewed-by: Mark Brown >> Acked-by: Robin Murphy Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds