From: Geert Uytterhoeven Subject: Re: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of platform dependency Date: Tue, 20 Mar 2018 11:09:06 +0100 Message-ID: References: <1521208314-4783-1-git-send-email-geert@linux-m68k.org> <1521208314-4783-11-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Ulf Hansson , Wolfram Sang , "linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org" , Bjorn Andersson , Eric Anholt , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux1394-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Christoph Hellwig , Stefan Wahren , Boris Brezillon , "James E . J . Bottomley" , Herbert Xu , "linux-s To: Madalin-cristian Bucur Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-crypto.vger.kernel.org Hi Madalin-cristian, On Mon, Mar 19, 2018 at 6:27 AM, Madalin-cristian Bucur wrote: >> -----Original Message----- >> From: netdev-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:netdev-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] >> On Behalf Of Geert Uytterhoeven >> Remove dependencies on HAS_DMA where a Kconfig symbol depends on >> another >> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". >> In most cases this other symbol is an architecture or platform specific >> symbol, or PCI. >> >> Generic symbols and drivers without platform dependencies keep their >> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that >> cannot work anyway. >> >> This simplifies the dependencies, and allows to improve compile-testing. >> >> Notes: >> - FSL_FMAN keeps its dependency on HAS_DMA, as it calls set_dma_ops(), >> which does not exist if HAS_DMA=n (Do we need a dummy? The use of >> set_dma_ops() in this driver is questionable), > > Hi, > > The set_dma_ops() is no longer required in the fsl/fman, I'll send a patch to remove it. Thank you, looking forward to it! >> - SND_SOC_LPASS_IPQ806X and SND_SOC_LPASS_PLATFORM loose their >> dependency on HAS_DMA, as they are selected from >> SND_SOC_APQ8016_SBC. >> >> Signed-off-by: Geert Uytterhoeven >> Reviewed-by: Mark Brown >> Acked-by: Robin Murphy Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds