From: Benjamin Warnke <4bwarnke@informatik.uni-hamburg.de> Subject: Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo Date: Thu, 22 Mar 2018 07:53:08 +0100 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Cc: Linux Crypto Mailing List , LKML , Herbert Xu , "David S. Miller" , minchan@kernel.org, Nitin Gupta , Sergey Senozhatsky To: Philippe Ombredanne Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org Hi Philippe, > Actually to be consistent if you want to use GPL-2-0 (and not "or > later") you should use: > > 1. at the top, for a c. file: > // SPDX-License-Identifier: GPL-2.0 > > or for a .h file: > /* SPDX-License-Identifier: GPL-2.0 */ > > The doc explains it all. Including the comment style (a topic that has > been discussed also on list quite bit: Linus had the final word there) > > 2. and in your MODULE_LICENSE macro: > > MODULE_LICENSE("GPL v2"); > > .... because a MODULE_LICENSE("GPL"); would mean GPL-2.0+ (e.g. or any > later version) and this would not match your top level license tag. Thanks, I have done this correctly in my files, but accidentally written it wrong in my mail. Cordinally Benjamin Warnke