From: Rob Herring Subject: Re: [PATCH v2 1/2] dt-bindings: rng: Add new compatible qcom,prng-v2 Date: Mon, 25 Jun 2018 13:06:09 -0600 Message-ID: <20180625190609.GA3586@rob-hp-laptop> References: <20180619095430.26358-1-vkoul@kernel.org> <20180619095430.26358-2-vkoul@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Mackall , Herbert Xu , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, Stephen Boyd , Vinod Koul , devicetree@vger.kernel.org To: Vinod Koul Return-path: Content-Disposition: inline In-Reply-To: <20180619095430.26358-2-vkoul@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Tue, Jun 19, 2018 at 03:24:29PM +0530, Vinod Koul wrote: > Later qcom chips support v2 of the prng, so add new compatible > qcom,prng-v2 for this. > > Signed-off-by: Vinod Koul > --- > > Cc: Rob Herring > Cc: devicetree@vger.kernel.org > Documentation/devicetree/bindings/rng/qcom,prng.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rng/qcom,prng.txt b/Documentation/devicetree/bindings/rng/qcom,prng.txt > index 8e5853c2879b..03fd218bd21a 100644 > --- a/Documentation/devicetree/bindings/rng/qcom,prng.txt > +++ b/Documentation/devicetree/bindings/rng/qcom,prng.txt > @@ -2,7 +2,8 @@ Qualcomm MSM pseudo random number generator. > > Required properties: > > -- compatible : should be "qcom,prng" > +- compatible : should be "qcom,prng" for 8916 etc > + : should be "qcom,prng-v2" for 8996 and later Either use SoC specific compatibles or convince me 'v2' is a meaningful and specific enough version. Some other QC IP has x.y.z versioning for example. > - reg : specifies base physical address and size of the registers map > - clocks : phandle to clock-controller plus clock-specifier pair > - clock-names : "core" clocks all registers, FIFO and circuits in PRNG IP block > -- > 2.14.4 >