From: Andy Lutomirski Subject: Re: [PATCH v1 2/3] zinc: Introduce minimal cryptography library Date: Tue, 7 Aug 2018 12:43:35 -0700 Message-ID: References: <20180801072246.GA15677@sol.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Eric Biggers , Linux Crypto Mailing List , LKML , Netdev , David Miller , Andrew Lutomirski , Greg Kroah-Hartman , Samuel Neves , "Daniel J . Bernstein" , Tanja Lange , Jean-Philippe Aumasson , Karthikeyan Bhargavan To: "Jason A. Donenfeld" , Ingo Molnar , Thomas Gleixner , linux-arch Return-path: In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Tue, Aug 7, 2018 at 11:54 AM, Jason A. Donenfeld wrote: > Hey Andy, Eric, & all, > > I've started the work of separating this out into 16 individual > commits, have addressed numerous other things brought up like the > ifdef maze, and have begun rewriting (parts of) the original commit > message. It's still a work in progress, and I still have some work to > do, but if you want to follow along, things are happening here: > > https://git.zx2c4.com/linux-dev/log/?h=jd/wireguard > > I'll be rebasing and reworking this continuously, but that's how it's > shaping up. > > As I'm still working on it, I won't be submitting v2 today, but if you > have suggestions or concerns or want to poke me while I'm working on > v2, don't hesitate to send me private email or ping me in IRC (I'm > "zx2c4" there) to chat. > > Regards, > Jason For "zinc: add simd helper", I think it should be in include/linux, and include/linux/simd.h should (immediately or maybe in the future) include to pick up arch-specific stuff. And the patch should get sent to linux-arch@vger.kernel.org. In your blake2s_arch() implementation, you're not passing in a simd_context_t. Is that still a work in progress? I thought the plan was to pass it in rather than doing the check in the _arch() functions.