From: Andy Lutomirski Subject: Re: [PATCH v1 2/3] zinc: Introduce minimal cryptography library Date: Thu, 9 Aug 2018 11:08:25 -0700 Message-ID: References: <20180801072246.GA15677@sol.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: Ingo Molnar , Thomas Gleixner , linux-arch , Eric Biggers , Linux Crypto Mailing List , LKML , Netdev , David Miller , Andrew Lutomirski , Greg Kroah-Hartman , Samuel Neves , "Daniel J . Bernstein" , Tanja Lange , Jean-Philippe Aumasson , Karthikeyan Bhargavan To: "Jason A. Donenfeld" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Tue, Aug 7, 2018 at 6:51 PM, Jason A. Donenfeld wrote: > On Tue, Aug 7, 2018 at 6:49 PM Andy Lutomirski wrot= e: >> I really wish we had a way to see that we use asm-generic=E2=80=99s copy= of a header in all cases except where an arch opts out. > > It's really not that hard to do -- symlink asm-generic to a target > called "asm" inside an otherwise empty directory, and add that > otherwise empty directory to the -I paths just after arch/include. > Since it's searched second, it's only used if the first fails. Maybe > I'm missing something though, as this seems a bit too obvious. Perhaps > a project for another day. The problem here (I think) is that it's preferable for stray files in the kernel tree to have no effect and, with this scheme, stray files in arch/*/include/asm could affect the build. So something explicit has an advantage. I just think there should be way to say "this asm-generic file should affect all arches unless they generic-n or override-generic-y it or whatever".