From: Andy Lutomirski Subject: Re: [PATCH net-next v6 02/23] zinc: introduce minimal cryptography library Date: Tue, 25 Sep 2018 13:00:08 -0700 Message-ID: <1BA7DB23-7BB6-46BA-A3E2-D65BC3CAF11C@amacapital.net> References: <20180925145622.29959-1-Jason@zx2c4.com> <20180925145622.29959-3-Jason@zx2c4.com> <2b5f2df2f1278c118a913259a44efdf589719293.camel@perches.com> Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Cc: Joe Perches , LKML , Netdev , Linux Crypto Mailing List , David Miller , Greg Kroah-Hartman , Samuel Neves , Andrew Lutomirski , Jean-Philippe Aumasson To: "Jason A. Donenfeld" Return-path: In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org > On Sep 25, 2018, at 12:43 PM, Jason A. Donenfeld wrote: >=20 >> On Tue, Sep 25, 2018 at 8:33 PM Joe Perches wrote: >> I think the -Dpr_fmt is especially odd and not >> really acceptable as it not used anywhere else >> in the kernel. >=20 > There are about 2000 cases in the kernel of the same '#define > pr_fmt...' being pasted into the top of the file, which seems a bit > cumbersome. Rather than having to paste that into each and every file > that I pr_err from, why can't I just do this from the makefile, since > I want that same pr_fmt to copy the whole directory? Because people like to be able to just read the C file to figure out what it= does. Or we could adopt the Makefile approach kernel-wide, since this use o= f it seems reasonable.=