From: "Jason A. Donenfeld" Subject: Re: [PATCH net-next v6 02/23] zinc: introduce minimal cryptography library Date: Tue, 25 Sep 2018 22:54:29 +0200 Message-ID: References: <20180925145622.29959-1-Jason@zx2c4.com> <20180925145622.29959-3-Jason@zx2c4.com> <2b5f2df2f1278c118a913259a44efdf589719293.camel@perches.com> <748429eee2fc77afd01630c24bd2cf66a545aec5.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: LKML , Netdev , Linux Crypto Mailing List , David Miller , Greg Kroah-Hartman , Samuel Neves , Andrew Lutomirski , Jean-Philippe Aumasson To: Joe Perches Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org Hi Joe, On Tue, Sep 25, 2018 at 10:21 PM Joe Perches wrote: > I'd still prefer as all these are effectively > debugging output that you convert the pr_info > uses pr_debug and so avoid using pr_fmt altogether. I started to write back, "sure no problem, this will be in v7," but then I gave it a closer look, and I think actually I'll be changing these into pr_err/pr_info and not naming this "DEBUG" but rather "SELFTEST", since I think these are actually very good to have beyond mere debugging. Jason