Return-Path: Received: from szxga04-in.huawei.com ([45.249.212.190]:17094 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729566AbfAIF6V (ORCPT ); Wed, 9 Jan 2019 00:58:21 -0500 Subject: Re: [PATCH -next] crypto: brcm - Fix some set-but-not-used warning To: Raveendra Padasalagi References: <1545968644-191671-1-git-send-email-yuehaibing@huawei.com> CC: Herbert Xu , Eric Biggers , Gilad Ben-Yossef , Stefan Agner , , From: YueHaibing Message-ID: <362516b3-0f1c-282b-a6fe-f094f6ea0db1@huawei.com> Date: Wed, 9 Jan 2019 13:58:14 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-crypto-owner@vger.kernel.org List-ID: On 2019/1/9 13:35, Raveendra Padasalagi wrote: > Hi YueHaibing, > > Please add below fixes tag in the commit message, > Fixes: 9d12ba86f818 ("crypto: brcm - Add Broadcom SPU driver") > > Otherwise patch looks good to me. Ok, will send v2, Thanks. > > -Raveendra > > On Fri, Dec 28, 2018 at 9:07 AM YueHaibing wrote: >> >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/crypto/bcm/cipher.c: In function 'handle_ahash_req': >> drivers/crypto/bcm/cipher.c:720:15: warning: >> variable 'chunk_start' set but not used [-Wunused-but-set-variable] >> >> drivers/crypto/bcm/cipher.c: In function 'spu_rx_callback': >> drivers/crypto/bcm/cipher.c:1679:31: warning: >> variable 'areq' set but not used [-Wunused-but-set-variable] >> >> drivers/crypto/bcm/cipher.c:1678:22: warning: >> variable 'ctx' set but not used [-Wunused-but-set-variable] >> >> Signed-off-by: YueHaibing >> --- >> drivers/crypto/bcm/cipher.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c >> index c9393ff..9a66c29 100644 >> --- a/drivers/crypto/bcm/cipher.c >> +++ b/drivers/crypto/bcm/cipher.c >> @@ -717,7 +717,7 @@ static int handle_ahash_req(struct iproc_reqctx_s *rctx) >> */ >> unsigned int new_data_len; >> >> - unsigned int chunk_start = 0; >> + unsigned int __maybe_unused chunk_start = 0; >> u32 db_size; /* Length of data field, incl gcm and hash padding */ >> int pad_len = 0; /* total pad len, including gcm, hash, stat padding */ >> u32 data_pad_len = 0; /* length of GCM/CCM padding */ >> @@ -1675,8 +1675,6 @@ static void spu_rx_callback(struct mbox_client *cl, void *msg) >> struct spu_hw *spu = &iproc_priv.spu; >> struct brcm_message *mssg = msg; >> struct iproc_reqctx_s *rctx; >> - struct iproc_ctx_s *ctx; >> - struct crypto_async_request *areq; >> int err = 0; >> >> rctx = mssg->ctx; >> @@ -1686,8 +1684,6 @@ static void spu_rx_callback(struct mbox_client *cl, void *msg) >> err = -EFAULT; >> goto cb_finish; >> } >> - areq = rctx->parent; >> - ctx = rctx->ctx; >> >> /* process the SPU status */ >> err = spu->spu_status_process(rctx->msg_buf.rx_stat); >> >> >> >> >> > > . >