Return-Path: Received: from mail.kernel.org ([198.145.29.99]:44314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726962AbfARGvB (ORCPT ); Fri, 18 Jan 2019 01:51:01 -0500 Date: Fri, 18 Jan 2019 07:50:58 +0100 From: Greg Kroah-Hartman To: Fabio Estevam Cc: Thomas Gleixner , LKML , Kate Stewart , Jonathan Corbet , Ondrej Mosnacek , Herbert Xu , "David S. Miller" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" Subject: Re: [patch 3/9] crypto: morus - Cleanup license mess Message-ID: <20190118065058.GA9727@kroah.com> References: <20190117231416.111952141@linutronix.de> <20190117231501.068505479@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, Jan 17, 2019 at 10:26:07PM -0200, Fabio Estevam wrote: > On Thu, Jan 17, 2019 at 9:17 PM Thomas Gleixner wrote: > > > --- a/include/crypto/morus1280_glue.h > > +++ b/include/crypto/morus1280_glue.h > > @@ -1,15 +1,10 @@ > > -/* SPDX-License-Identifier: GPL-2.0 */ > > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > > Shouldn't this be: /* SPDX-License-Identifier: GPL-2.0+ */ ? > > At least this is the form documented in Documentation/process/license-rules.rst: > > " License identifiers for licenses like [L]GPL with the 'or later' option > are constructed by using a "+" for indicating the 'or later' option.:: > > // SPDX-License-Identifier: GPL-2.0+" Either works, please see LICENSES/preferred/GPL-2.0 Personally, I think we should stick with the "+" version as that is the much more prevalent use in the kernel at the moment, but it's Thomas's call, not mine. thanks, greg k-h