Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE181C282C5 for ; Thu, 24 Jan 2019 07:58:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8751B21872 for ; Thu, 24 Jan 2019 07:58:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=benyossef-com.20150623.gappssmtp.com header.i=@benyossef-com.20150623.gappssmtp.com header.b="DuVSRX2A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726060AbfAXH6c (ORCPT ); Thu, 24 Jan 2019 02:58:32 -0500 Received: from mail-vs1-f68.google.com ([209.85.217.68]:40356 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbfAXH6c (ORCPT ); Thu, 24 Jan 2019 02:58:32 -0500 Received: by mail-vs1-f68.google.com with SMTP id z3so2980883vsf.7 for ; Wed, 23 Jan 2019 23:58:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=benyossef-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=krVR0RuMpCJWesgiRw/G3mLFSaTJr/cS7jpVt5y4yTA=; b=DuVSRX2A6xh/6/3Vp8CUlWqeqMzPhevp7ZR/OvbMkmV1fDHcDQA/HFcPhMOeCOsJd+ aefCZdTYZCtnv93Se1llzvjH60RSC0gg8OGd28TJe8nXYMA0lRLjmI+jrwPRE1cFY0yh oVvHUuxedpoHei33GANK1H4T0lfXEom825BiXNt43gNSC+kfopw2QKel9+nsV3+kA1sZ +Sr0L7WaiyjDNI9YWeK1/5zJPjF66inx7OlD7M/ITMbvcq6+CloUTWdMXfQpZIHWZ4tV sG+7INJzikpQTwCpaUdsb5HCzlJFZV6mkXAcpifVCZHL+8nCpzCOB3xzLwgM6DTgXOow MXmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=krVR0RuMpCJWesgiRw/G3mLFSaTJr/cS7jpVt5y4yTA=; b=A/b6YCtyMJmMiNTtKQFdMBU5nfd8Z0o57CkXU9v/eJakfZM90vUuk30cUxx4E15kIS t4qJ+yW2PJr34lRJKe6OGetEsRoh95yoU4DBBT7g4VJtQvpP0LPjOvN+I00gIgmGQEyL ciUkU2daNTSEOXK4fZPLtGjFg3RyH1qNclSBiG/w2vADKWKRGggwFAYEbnn0pRSO80Ig SHjsIEFCQEaKV8XmsjMKXIh+SEoYQF4j/Ac+KH36gE6KugllSMhf9FbOwdJw15X9YzKV kL/UAXDdnc45juansZJNFYkqaMbsaKmgnqQWg1LkJPdCORIU3lIq/3eqz2izXTEbDFAq 4/nw== X-Gm-Message-State: AJcUukdL7V7UpUSSdtTQ6xq6o5W4AREoSw7aUSfbDAinaU49Vz7Tn3vI UiBxZX7lEO/VuRGIIkH6H4VetgJ++IApttYu6U3fEQ== X-Google-Smtp-Source: ALg8bN6TcJWCXfdu9u8s4v3gL08dDaH8MFOb5hucWLzLoF2BxKJFWcQV1ZunwrxhBet56OcybYOEZEbZlnQi+bSSq7M= X-Received: by 2002:a67:f445:: with SMTP id r5mr2430437vsn.164.1548316710929; Wed, 23 Jan 2019 23:58:30 -0800 (PST) MIME-Version: 1.0 References: <20190122151422.14204-1-gregkh@linuxfoundation.org> <20190122151422.14204-3-gregkh@linuxfoundation.org> <20190123133734.GA24700@kroah.com> In-Reply-To: <20190123133734.GA24700@kroah.com> From: Gilad Ben-Yossef Date: Thu, 24 Jan 2019 09:58:20 +0200 Message-ID: Subject: Re: [PATCH 2/7] crypto: ccrree: no need to check return value of debugfs_create functions To: Greg Kroah-Hartman Cc: Herbert Xu , David Miller , Linux kernel mailing list , Linux Crypto Mailing List , Yael Chemla Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jan 23, 2019 at 3:37 PM Greg Kroah-Hartman wrote: > > On Wed, Jan 23, 2019 at 02:58:22PM +0200, Gilad Ben-Yossef wrote: > > Hi, > > > > On Tue, Jan 22, 2019 at 5:14 PM Greg Kroah-Hartman > > wrote: > > > > > > When calling debugfs functions, there is no need to ever check the > > > return value. The function can work or not, but the code logic shoul= d > > > never do something different based on this. > > > > > > > > I get the part about not failing loading the driver just because some > > debugs entry isn't available, but wont it be weird if > > debugfs_create_dir() fails but debugfs_create_regset32() succeeds and > > we suddenly have weird files in the debugfs root dir? > > Not the end of the world of course but maybe it's better to avoid > > trying to create the files if the directory is not available? > > See this patch to handle that theoretical issue: > > https://lore.kernel.org/lkml/20190123130917.GZ4087@dhcp22.suse.cz= /T/#me91cc3d16185be13d64f85c8477c543cbda9baf6 > Ah, sorry. I've missed that. Acked-By: Gilad Ben-Yossef Thanks! Gilad --=20 Gilad Ben-Yossef Chief Coffee Drinker values of =CE=B2 will give rise to dom!