MIME-Version: 1.0
References: <20190123224926.250525-1-ebiggers@kernel.org> <20190123224926.250525-12-ebiggers@kernel.org>
 <CAKv+Gu-uELtKc_fNKFLPZ9KqrSMhX+cXuiP79JMR1zm0yo0r8w@mail.gmail.com> <20190124131414.GA13624@Red>
In-Reply-To: <20190124131414.GA13624@Red>
From:   Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Thu, 24 Jan 2019 15:09:40 +0100
Message-ID: <CAKv+Gu_HNsjYkkDPUYY9bJ_u0MMf1mcYfTMydE6-TW7iR6QDNQ@mail.gmail.com>
Subject: Re: [RFC/RFT PATCH 11/15] crypto: testmgr - convert skcipher testing
 to use testvec_configs
To:     Corentin Labbe <clabbe.montjoie@gmail.com>
Cc:     Eric Biggers <ebiggers@kernel.org>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Jason A . Donenfeld" <Jason@zx2c4.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Thu, 24 Jan 2019 at 14:14, Corentin Labbe <clabbe.montjoie@gmail.com> wrote:
>
> On Thu, Jan 24, 2019 at 01:36:23PM +0100, Ard Biesheuvel wrote:
> > On Wed, 23 Jan 2019 at 23:53, Eric Biggers <ebiggers@kernel.org> wrote:
> > >
> > > From: Eric Biggers <ebiggers@google.com>
> > >
> > > Convert alg_test_skcipher() to use the new test framework, adding a list
> > > of testvec_configs to test by default.  When the extra self-tests are
> > > enabled, randomly generated testvec_configs are tested as well.
> > >
> > > This improves skcipher test coverage mainly because now all algorithms
> > > have a variety of data layouts tested, whereas before each algorithm was
> > > responsible for declaring its own chunked test cases which were often
> > > missing or provided poor test coverage.  The new code also tests both
> > > the MAY_SLEEP and !MAY_SLEEP cases, different IV alignments, and buffers
> > > that cross pages.
> > >
> > > This has already found a bug in the arm64 ctr-aes-neonbs algorithm.
> > > It would have easily found many past bugs.
> > >
> > > I removed the skcipher chunked test vectors that were the same as
> > > non-chunked ones, but left the ones that were unique.
> > >
> > > Signed-off-by: Eric Biggers <ebiggers@google.com>
> >
> > This patch does not apply after applying 1..10 onto cryptodev/master
> >
> > Do you have a tree somewhere?
>
> Hello
>
> I got the same with next.
> You need to apply "crypto: clarify name of WEAK_KEY request flag" from his repo:
> https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git branch testmgr-improvements
>

Thanks

I just pulled that branch entirely instead.