Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14CA0C282C6 for ; Sat, 26 Jan 2019 02:09:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB69A218B0 for ; Sat, 26 Jan 2019 02:09:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729486AbfAZCJK (ORCPT ); Fri, 25 Jan 2019 21:09:10 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:45460 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725550AbfAZCJK (ORCPT ); Fri, 25 Jan 2019 21:09:10 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1gnDPA-0007ed-No; Sat, 26 Jan 2019 10:09:08 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1gnDP5-0004FJ-0k; Sat, 26 Jan 2019 10:09:03 +0800 Date: Sat, 26 Jan 2019 10:09:03 +0800 From: Herbert Xu To: Horia Geanta Cc: Roland Hieber , Aymen Sghaier , "linux-crypto@vger.kernel.org" , Jesper Nilsson , Lars Persson , Christian Lamparter , Roland Hieber , "David S. Miller" , "kernel@pengutronix.de" Subject: Re: [PATCH 2/2] crypto: caam - fix DMA mapping of stack memory Message-ID: <20190126020902.wponojerg4a2cuhi@gondor.apana.org.au> References: <20190122152651.1150-1-rhi@pengutronix.de> <20190125134756.5f5e2uxmwvtnc6bb@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Jan 25, 2019 at 02:26:27PM +0000, Horia Geanta wrote: > > Thus, it seems the problem lies in the fact that ahash_request structure defines > the digest buffer as "u8 *result" - thus the memory area might not be DMAable. Oh OK, I misunderstood. Anything that's in the form of a kernel pointer must be assumed to be not DMAable. So yes this needs to be copied. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt