Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63997C282D8 for ; Fri, 1 Feb 2019 06:50:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F31F20870 for ; Fri, 1 Feb 2019 06:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726414AbfBAGt7 (ORCPT ); Fri, 1 Feb 2019 01:49:59 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:56962 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbfBAGt7 (ORCPT ); Fri, 1 Feb 2019 01:49:59 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1gpSe9-0000A6-Dx; Fri, 01 Feb 2019 14:49:53 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1gpSe7-0005ma-VO; Fri, 01 Feb 2019 14:49:51 +0800 Date: Fri, 1 Feb 2019 14:49:51 +0800 From: Herbert Xu To: Corentin Labbe Cc: chunkeey@googlemail.com, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto4xx: Fix wrong ppc4xx_trng_probe()/ppc4xx_trng_remove() arguments Message-ID: <20190201064951.ecnljqb4xji57grj@gondor.apana.org.au> References: <1548242658-9395-1-git-send-email-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548242658-9395-1-git-send-email-clabbe@baylibre.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jan 23, 2019 at 11:24:18AM +0000, Corentin Labbe wrote: > When building without CONFIG_HW_RANDOM_PPC4XX, I hit the following build failure: > drivers/crypto/amcc/crypto4xx_core.c: In function 'crypto4xx_probe': > drivers/crypto/amcc/crypto4xx_core.c:1407:20: error: passing argument 1 of 'ppc4xx_trng_probe' from incompatible pointer type [-Werror=incompatible-pointer-types] > In file included from drivers/crypto/amcc/crypto4xx_core.c:50:0: > drivers/crypto/amcc/crypto4xx_trng.h:28:20: note: expected 'struct crypto4xx_device *' but argument is of type 'struct crypto4xx_core_device *' > drivers/crypto/amcc/crypto4xx_core.c: In function 'crypto4xx_remove': > drivers/crypto/amcc/crypto4xx_core.c:1434:21: error: passing argument 1 of 'ppc4xx_trng_remove' from incompatible pointer type [-Werror=incompatible-pointer-types] > In file included from drivers/crypto/amcc/crypto4xx_core.c:50:0: > drivers/crypto/amcc/crypto4xx_trng.h:30:20: note: expected 'struct crypto4xx_device *' but argument is of type 'struct crypto4xx_core_device *' > > This patch fix the needed argument of ppc4xx_trng_probe()/ppc4xx_trng_remove() in that case. > > Fixes: 5343e674f32f ("crypto4xx: integrate ppc4xx-rng into crypto4xx") > Signed-off-by: Corentin Labbe > --- > drivers/crypto/amcc/crypto4xx_trng.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt