Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF0BDC169C4 for ; Fri, 8 Feb 2019 07:47:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8504921917 for ; Fri, 8 Feb 2019 07:47:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726977AbfBHHrH (ORCPT ); Fri, 8 Feb 2019 02:47:07 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:34206 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbfBHHrH (ORCPT ); Fri, 8 Feb 2019 02:47:07 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1gs0sL-0000lc-73; Fri, 08 Feb 2019 15:47:05 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1gs0sJ-0002SK-Qs; Fri, 08 Feb 2019 15:47:03 +0800 Date: Fri, 8 Feb 2019 15:47:03 +0800 From: Herbert Xu To: "Singh, Brijesh" Cc: "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Lendacky, Thomas" , "Hook, Gary" Subject: Re: [PATCH] crypto: ccp - fix the SEV probe in kexec boot path Message-ID: <20190208074703.ydqn6u75bbtkurhg@gondor.apana.org.au> References: <20190130205710.14268-1-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190130205710.14268-1-brijesh.singh@amd.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jan 30, 2019 at 08:57:52PM +0000, Singh, Brijesh wrote: > A kexec reboot may leave the firmware in INIT or WORKING state. > Currently, we issue PLATFORM_INIT command during the probe without > checking the current state. The PLATFORM_INIT command fails if the > FW is already in INIT state. Lets check the current state, if FW > is not in UNINIT state then transition it to UNINIT before > initializing or upgrading the FW. > > Signed-off-by: Brijesh Singh > Cc: Tom Lendacky > Cc: Gary Hook > Reviewed-by: Tom Lendacky > --- > drivers/crypto/ccp/psp-dev.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt