Subject: Re: [Bug] s5p-sss crypto driver doesn't set next AES-CBC IV
To:     Eric Biggers <ebiggers@kernel.org>,
        Christoph Manszewski <c.manszewski@samsung.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Vladimir Zapolskiy <vz@mleia.com>,
        linux-samsung-soc@vger.kernel.org
Cc:     linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org
From:   Kamil Konieczny <k.konieczny@partner.samsung.com>
Message-ID: <a78f8033-954f-8b59-b361-557acef3acdd@partner.samsung.com>
Date:   Tue, 19 Feb 2019 10:58:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
        Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190215185058.GB12909@gmail.com>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20190215185148epcas3p23960bfe37c629ebb2103e673509949f4@epcas3p2.samsung.com>
        <20190215185058.GB12909@gmail.com>
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

Hi,

On 15.02.2019 19:51, Eric Biggers wrote:
> Hello,
> 
> The AES-CBC implementation in the s5p-sss crypto driver is failing the improved
> crypto self-tests I currently have out for review.  The improved tests check
> that all CBC implementations update the IV buffer to be the last ciphertext
> block.  This has always been required so that requests can be chained, but
> unfortunately it wasn't tested for by the self-tests until now.
> 
> See the boot logs for Exynos platforms from the KernelCI job here:
> https://kernelci.org/boot/all/job/ardb/branch/for-kernelci/kernel/v5.0-rc1-149-g64c945c018af/
> 
> alg: skcipher: cbc-aes-s5p encryption test failed (wrong output IV) on test vector 0, cfg=\"in-place\"
> 00000000: 3d af ba 42 9d 9e b4 30 b4 22 da 80 2c 9f ac 41
> [...]

I checked dmesg logs after my patch with:

root@target:~# dmesg |grep alg: |grep aes                                       
[    4.087168] crypto: alg: self-tests for aes-generic (aes) passed             
[    6.305202] crypto: alg: self-tests for ecb-aes-s5p (ecb(aes)) passed        
[    6.405489] crypto: alg: self-tests for cbc-aes-s5p (cbc(aes)) passed        
[    6.505000] crypto: alg: self-tests for ctr-aes-s5p (ctr(aes)) passed

and I noticed there are no cbc-aes-generic nor ctr-aes-generic

Did you test them in separate tree ? Why they are not registered in /proc/crypto ?

-- 
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland