Date:   Fri, 22 Feb 2019 20:01:01 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     "Lendacky, Thomas" <Thomas.Lendacky@amd.com>
Cc:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        "Singh, Brijesh" <brijesh.singh@amd.com>,
        "Hook, Gary" <Gary.Hook@amd.com>,
        David Miller <davem@davemloft.net>
Subject: Re: [PATCH] crypto: ccp - Update driver messages to remove some
 confusion
Message-ID: <20190222120101.demmblj6ri4hkckk@gondor.apana.org.au>
References: <155025159161.22636.12469459044882251074.stgit@tlendack-t1.amdoffice.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <155025159161.22636.12469459044882251074.stgit@tlendack-t1.amdoffice.net>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 15, 2019 at 05:26:33PM +0000, Lendacky, Thomas wrote:
> The current content of some of the driver messages and the way that they
> are issued results in some confusion, especially in the area of the PSP
> as it relates to SEV support. If SEV is not supported, a message is issued
> that says "psp initialization failed." This makes it seem like there was
> a problem, when in fact, the PSP support is just disabled if SEV is not
> supported.
> 
> Update the driver to check SEV support a bit earlier and issue a debug-
> level message if SEV is not supported, followed by a debug-level message
> that the PSP is disabled. This way you will only see PSP messages if SEV
> is supported or if debug information is desired. Also, remove the overall
> "enabled" and "disabled" messages for the driver and rely on the CCP and
> PSP support to issue component-specific messages.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  drivers/crypto/ccp/psp-dev.c |   19 ++++++++++++++-----
>  drivers/crypto/ccp/sp-pci.c  |    4 ----
>  2 files changed, 14 insertions(+), 9 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt