Date:   Wed, 27 Mar 2019 15:07:06 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Andrej Shadura <andrew.shadura@collabora.co.uk>
cc:     linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
        kernel@collabora.com, Theodore Ts'o <tytso@mit.edu>,
        Vasily Khoruzhick <anarsoul@gmail.com>,
        Nick Kossifidis <mickflemm@gmail.com>,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2] HID: add driver for U2F Zero built-in LED and RNG
In-Reply-To: <02f265dd-5ccd-7c42-2bde-b7c5e354cd69@collabora.co.uk>
Message-ID: <nycvar.YFH.7.76.1903271506140.19912@cbobk.fhfr.pm>
References: <20190309183213.7598-1-andrew.shadura@collabora.co.uk> <nycvar.YFH.7.76.1903181542260.19912@cbobk.fhfr.pm> <02f265dd-5ccd-7c42-2bde-b7c5e354cd69@collabora.co.uk>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Mon, 18 Mar 2019, Andrej Shadura wrote:

> > 
> > This driver isn't really a generic (transport-agnostic) one (which also 
> > means it's missing USB dependency in Kconfig btw).
> 
> Thanks, I forgot that one.
> 
> > Is there a reason why it can't be abstracted that way so that it'd fit our 
> > principal model in HID subsystem?
> 
> I tried and I failed. The HID subsystem doesn’t provide the 
> functionality necessary to implement the protocol, or maybe I’m missing 
> something, but I haven’t found a way.

After reading through the driver, I tend to agree that this is the least 
painful way, so it's probably worth violating our usual mode of operation 
a bit :)

So could you please resend with the proper USB dependency added?

Thanks,

-- 
Jiri Kosina
SUSE Labs