Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7BEC10F0E for ; Sun, 7 Apr 2019 12:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F7A9213F2 for ; Sun, 7 Apr 2019 12:42:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726246AbfDGMm6 (ORCPT ); Sun, 7 Apr 2019 08:42:58 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:52958 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbfDGMm6 (ORCPT ); Sun, 7 Apr 2019 08:42:58 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hD784-0006lJ-0H; Sun, 07 Apr 2019 20:42:32 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hD77j-0002ax-6n; Sun, 07 Apr 2019 20:42:11 +0800 Date: Sun, 7 Apr 2019 20:42:11 +0800 From: Herbert Xu To: Eric Biggers Cc: Pascal Van Leeuwen , Zhang Zhijie , Heiko Stuebner , Ard Biesheuvel , Zain Wang , Arnd Bergmann , "linux-rockchip@lists.infradead.org" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Olof Johansson , "ezequiel@collabora.com" , linux-arm-kernel , Tao Huang Subject: Re: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext Message-ID: <20190407124211.fv7pjsozxhnhw56i@gondor.apana.org.au> References: <20190126210530.GB709@sol.localdomain> <1894799.pWIprST79S@phil> <20190315033140.GB1671@sol.localdomain> <20190404171204.GA121392@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190404171204.GA121392@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Apr 04, 2019 at 10:12:05AM -0700, Eric Biggers wrote: > > Herbert, can you explain what users actually rely on the next IV being returned? > I don't know all the historical context behind this. Chaining by reusing the output IV has always been part of the API. However, we never tested it in testmgr though so a number of drivers are broken in this regard. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt