Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 906D7C282CE for ; Mon, 8 Apr 2019 05:53:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 698832083E for ; Mon, 8 Apr 2019 05:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbfDHFx2 (ORCPT ); Mon, 8 Apr 2019 01:53:28 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:43204 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726343AbfDHFx2 (ORCPT ); Mon, 8 Apr 2019 01:53:28 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hDNDh-0007RI-Dg; Mon, 08 Apr 2019 13:53:25 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hDNDe-0003MQ-OR; Mon, 08 Apr 2019 13:53:22 +0800 Date: Mon, 8 Apr 2019 13:53:22 +0800 From: Herbert Xu To: Eric Biggers Cc: linux-crypto@vger.kernel.org Subject: Re: [RFC/RFT PATCH 18/18] crypto: run initcalls for generic implementations earlier Message-ID: <20190408055322.kke6emtixhhbkppn@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190331200428.26597-19-ebiggers@kernel.org> X-Newsgroups: apana.lists.os.linux.cryptoapi Organization: Core User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Eric: Eric Biggers wrote: > From: Eric Biggers > > Use subsys_initcall for registration of all templates and generic > algorithm implementations, rather than module_init. I think this is fine except that algboss already hooks in at subsys_initcall and either it needs to move further up or we need to change these ones to occur after subsys_initcall. Otherwise the generic algorithms themselves may not get tested if algboss isn't loaded first. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt