Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA92C282CE for ; Mon, 8 Apr 2019 05:59:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45B4620855 for ; Mon, 8 Apr 2019 05:59:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726349AbfDHF7I (ORCPT ); Mon, 8 Apr 2019 01:59:08 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:43398 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725877AbfDHF7I (ORCPT ); Mon, 8 Apr 2019 01:59:08 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hDNIy-0007Wg-9G; Mon, 08 Apr 2019 13:58:52 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hDNIn-0003Mz-Ar; Mon, 08 Apr 2019 13:58:41 +0800 Date: Mon, 8 Apr 2019 13:58:41 +0800 From: Herbert Xu To: Pascal Van Leeuwen Cc: Eric Biggers , Zhang Zhijie , Heiko Stuebner , Ard Biesheuvel , Zain Wang , Arnd Bergmann , "linux-rockchip@lists.infradead.org" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Olof Johansson , "ezequiel@collabora.com" , linux-arm-kernel , Tao Huang Subject: Re: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext Message-ID: <20190408055841.xa5dof4e5xqgaitv@gondor.apana.org.au> References: <20190126210530.GB709@sol.localdomain> <1894799.pWIprST79S@phil> <20190315033140.GB1671@sol.localdomain> <20190404171204.GA121392@gmail.com> <20190407124211.fv7pjsozxhnhw56i@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Apr 07, 2019 at 07:12:43PM +0000, Pascal Van Leeuwen wrote: > > Then where is this specified? Because I read through all the Kernel Crypto > API documentation multiple times, but I have not been able to find ANY > reference to any output IV being stored anywhere. > Yes, I can infer from the source code that this is what the standard CBC > wrapper does, but that may just as well have been a side-effect of that > particular implementation. Patches to improve the documentation are welcome. > So why would we fail and disable crypto drivers that have been working > perfectly fine so far on their true use cases just because of some purely > theoretical "part of the API" that may just as well be personal opinion? Any drivers not obeying this API rule will be broken when used in conjunction with algif_skcipher as well as templates such as cts. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt