Date:   Wed, 10 Apr 2019 14:02:49 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Andrej Shadura <andrew.shadura@collabora.co.uk>
cc:     linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
        Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
        kernel@collabora.com, Theodore Ts'o <tytso@mit.edu>,
        Vasily Khoruzhick <anarsoul@gmail.com>,
        Nick Kossifidis <mickflemm@gmail.com>,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH v3] HID: add driver for U2F Zero built-in LED and RNG
In-Reply-To: <20190401124200.17331-1-andrew.shadura@collabora.co.uk>
Message-ID: <nycvar.YFH.7.76.1904101400520.9803@cbobk.fhfr.pm>
References: <20190401124200.17331-1-andrew.shadura@collabora.co.uk>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Mon, 1 Apr 2019, Andrej Shadura wrote:

> U2F Zero supports custom commands for blinking the LED and getting data
> from the internal hardware RNG. Expose the blinking function as a LED
> device, and the internal hardware RNG as an HWRNG so that it can be used
> to feed the enthropy pool.

So I still am not really happy about this being wired up into generic HID 
although it's really a USB driver, but we've discussed that already, and I 
don't see any option that'd work substantially better in this case, 
especially from the UX point of view. Oh well. Applied to for-5.2/u2fzero, 
thanks!

-- 
Jiri Kosina
SUSE Labs