Date:   Thu, 11 Apr 2019 11:45:06 -0700
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     Atul Gupta <atul.gupta@chelsio.com>
Cc:     herbert@gondor.apana.org.au, davem@davemloft.net,
        linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
        dt@chelsio.com
Subject: Re: [crypto 0/4] Inline TLS client and v6 support
Message-ID: <20190411114506.10d19a40@cakuba.netronome.com>
In-Reply-To: <ae56c100-d072-bf6b-465a-5136d29b84be@chelsio.com>
References: <20190409152234.11100-1-atul.gupta@chelsio.com>
        <20190409110137.1ff359e0@cakuba.netronome.com>
        <a443baa3-a192-2d3d-d3bf-20b0f12e53a4@chelsio.com>
        <20190410085842.687f2d2f@cakuba.netronome.com>
        <601354bc-10b7-f008-c3d2-88d715eba812@chelsio.com>
        <20190411094010.61f93a25@cakuba.netronome.com>
        <ae56c100-d072-bf6b-465a-5136d29b84be@chelsio.com>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Thu, 11 Apr 2019 23:13:08 +0530, Atul Gupta wrote:
> On 4/11/2019 10:10 PM, Jakub Kicinski wrote:
> > On Thu, 11 Apr 2019 09:47:09 +0530, Atul Gupta wrote:  
> >> On 4/10/2019 9:28 PM, Jakub Kicinski wrote:  
> >>> On Wed, 10 Apr 2019 10:56:37 +0530, Atul Gupta wrote:    
> >>>> On 4/9/2019 11:31 PM, Jakub Kicinski wrote:    
> >>>>> On Tue,  9 Apr 2019 08:22:34 -0700, Atul Gupta wrote:      
> >>>>>> Extends Inline TLS record processing to TLS client. connect
> >>>>>> API is added to tls_context to setup hardware for TLS
> >>>>>> connection and handshake. Functionality wise, this makes the solution
> >>>>>> end-to-end Inline TLS capable. TLS server and client
> >>>>>> can operate in Inline mode and leverage hardware for complete
> >>>>>> TLS record offload.
> >>>>>> [0004] Adds the IPv6 support for Inline TLS server/client.
> >>>>>>
> >>>>>> RFC series for this patch was created against net-next and 
> >>>>>> submitted on 18 Jan'2019.
> >>>>>> This series is created against Herbert branch.      
> >>>>> Sorry if someone already asked this, but is your HW doing full ToE 
> >>>>> for all this TLS "record offload" stuff?      
> >>>> Yes Jakub    
> >>> So from what I grok you already feed all the data directly to the
> >>> socket completely bypassing the lower layers of the networking stack,
> >>> and with this patch set you'd also move 3WHS into the FW?    
> >> Yes, that's correct.  
> > I believe then it's a no-go from netdev perspective.  
>
> Inline TLS record offload path is kept out of netdev and leverages
> offload capabilities for crypto

Inline TLS record offload path bypasses the networking stack and feeds
data directly into the socket.  If we also allow offloading 3WHS the
connection will become invisible to the stack, queueing, packet
filtering etc.

I think the "netdev community" feels pretty strongly about preventing
protocol ossification and bypassing crucial parts of the infrastructure.