Subject: Re: [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA
To:     Vitaly Chikunov <vt@altlinux.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>
References: <20190423162954.7859-1-vt@altlinux.org>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <3b74a3e8-d915-8ff3-186f-c5a774d00bc3@infradead.org>
Date:   Tue, 23 Apr 2019 13:20:30 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190423162954.7859-1-vt@altlinux.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On 4/23/19 9:29 AM, Vitaly Chikunov wrote:
> Fix undefined symbol issue in ecrdsa_generic module when ASN1
> or OID_REGISTRY aren't enabled in the config by selecting these
> options for CRYPTO_ECRDSA.
> 
> ERROR: "asn1_ber_decoder" [crypto/ecrdsa_generic.ko] undefined!
> ERROR: "look_up_OID" [crypto/ecrdsa_generic.ko] undefined!
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

My tools would prefer to see the diff at one tree level higher:


> ---
>  crypto/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git crypto/Kconfig crypto/Kconfig

  diff --git a/crypto/Kconfig b/crypto/Kconfig

for any spelling of a and b.


> index 4446833f6eca..3d056e7da65f 100644
> --- crypto/Kconfig
> +++ crypto/Kconfig

  --- a/crypto/Kconfig
  +++ b/crypto/Kconfig

> @@ -264,6 +264,8 @@ config CRYPTO_ECRDSA
>  	select CRYPTO_ECC
>  	select CRYPTO_AKCIPHER
>  	select CRYPTO_STREEBOG
> +	select OID_REGISTRY
> +	select ASN1
>  	help
>  	  Elliptic Curve Russian Digital Signature Algorithm (GOST R 34.10-2012,
>  	  RFC 7091, ISO/IEC 14888-3:2018) is one of the Russian cryptographic
> 


-- 
~Randy