Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3801280yba; Mon, 29 Apr 2019 08:44:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqyGVpToOmIOpnjd/gpQGNxZzQxzZ1VoZUIm03yyI/GpewV/u5zQt0M5kDjOBpTHt14r0HBK X-Received: by 2002:a62:2541:: with SMTP id l62mr41468335pfl.243.1556552681522; Mon, 29 Apr 2019 08:44:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556552681; cv=none; d=google.com; s=arc-20160816; b=PP09YFgui8MT3mkVbHN2VXhOgO3Ep37uB+xVOq52MJGxaKU3bx3eKaafAUdmUXG0Fa Zsp0Fp/SH4XvMbVXW61J+JBhJi+MX61uDt+Ssw5oIUDKUGwy9rkj7PfcM8Q0L6nz2gMn 7ncuPWfbyaAKlKX98oqvwPXP1l8i+5SSCIyGuW9T6rYfl3vDb79JGi9j5+JMW7DSEIPo TFs4xmOdPdHqOA411Vb71vv2iR1KaRyJiCbJsuR6wUFD6/UeCr8OKk/Y3r/VNo7IA6NJ NN7K+8kXCSFSJPd6bHZjZyX3mMvQj/dlIcJkNidSN9M0N3uSlIQGu91+GeL8avUK37TM 5v6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=VUiCtpOEqTOotWVIWNzDbXjWxeGDFgZ2sdmBu2xuxBs=; b=O0PfRzgGMnAugA4bGP0BVH/AFDF+mAE31o7YqfmvpljvJrkoPTclhKQJpaaO+J7Jaa PPoHoZfFfO6DroCTs9GAwiYgbAWlHNF+21Cnnt/VOINah8lQNyhB7sJjJXjrhyRprIvv iD4On8h8Xo5/Ei7aTEIhNBVzd2KR/ufHhgxbMs30vQIK5rpNkvKw8vC1dE0Ywdr4tr70 UfNd6l6qgsQVBwAMGL/xkJrJ1MzjnfCfs/Z+hlIDVSHsS9W8bD2ufXZICkEJtc9LX/+b f85CVsJ6pocU2WBQbqHetWzCf3S7XvFgiaAOHCi35tFRY2u2tQ7PD8aFtrXknoNqp3x/ W7bg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g123si35217568pfb.24.2019.04.29.08.44.28; Mon, 29 Apr 2019 08:44:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728483AbfD2PoN (ORCPT + 99 others); Mon, 29 Apr 2019 11:44:13 -0400 Received: from mga14.intel.com ([192.55.52.115]:4152 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728438AbfD2PoN (ORCPT ); Mon, 29 Apr 2019 11:44:13 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Apr 2019 08:44:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,410,1549958400"; d="scan'208";a="319990352" Received: from silvixa00391824.ir.intel.com (HELO silvixa00391824.ger.corp.intel.com) ([10.237.222.24]) by orsmga005.jf.intel.com with ESMTP; 29 Apr 2019 08:44:11 -0700 From: Giovanni Cabiddu To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, Shant KumarX Sonnad , Conor Mcloughlin , Sergey Portnoy , Giovanni Cabiddu Subject: [PATCH 2/7] crypto: qat - add check for negative offset in alg precompute function Date: Mon, 29 Apr 2019 16:43:16 +0100 Message-Id: <20190429154321.21098-2-giovanni.cabiddu@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190429154321.21098-1-giovanni.cabiddu@intel.com> References: <20190429154321.21098-1-giovanni.cabiddu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org From: Shant KumarX Sonnad The offset is calculated based on type of hash algorithum. If the algorithum is invalid the offset can have negative value. Hence added negative offset check and return -EFAULT. Reviewed-by: Conor Mcloughlin Tested-by: Sergey Portnoy Signed-off-by: Shant KumarX Sonnad Signed-off-by: Giovanni Cabiddu --- drivers/crypto/qat/qat_common/qat_algs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/qat/qat_common/qat_algs.c b/drivers/crypto/qat/qat_common/qat_algs.c index 413e05e8891e..b60156d987eb 100644 --- a/drivers/crypto/qat/qat_common/qat_algs.c +++ b/drivers/crypto/qat/qat_common/qat_algs.c @@ -222,6 +222,9 @@ static int qat_alg_do_precomputes(struct icp_qat_hw_auth_algo_blk *hash, return -EFAULT; offset = round_up(qat_get_inter_state_size(ctx->qat_hash_alg), 8); + if (offset < 0) + return -EFAULT; + hash_state_out = (__be32 *)(hash->sha.state1 + offset); hash512_state_out = (__be64 *)hash_state_out; -- 2.20.1