Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3801350yba; Mon, 29 Apr 2019 08:44:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqwmWuEPUegGwVpR8lbGLUAUJ6k6fZCcGTrJCdSJI2RXMN0On6S9GkQNaTCIZtoVa32IwDy5 X-Received: by 2002:a17:902:266:: with SMTP id 93mr62854177plc.201.1556552686508; Mon, 29 Apr 2019 08:44:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556552686; cv=none; d=google.com; s=arc-20160816; b=JdLe10Xj3u17yWJHssoc2uC36D0M08y0rsxaUnOtTQ/pGHzv0HPYXvK2W1CcAdjjfm eKy7p1pt2gbrC6e6ghA42+DlrSLjKfntW3Yv9dzVSQcUtkaHZ2mTgnGa1dOrblvAJhUi Vzw5sE1nhKFE2kZZ1kIez51LQS219kaTcH7u+bxwXq+JqsDyEwzE7z/vJ2eHEC7z3I6h ski9k1m3yfwWu2y2Hta8MH1pxewur/rkPiI3izwm6lHiYt+v6JXBakq1TDVEaeTDuz/H id7Y5TSTRRZmdC8OT/X6ZDRv2hSAf4CsvVZ1RZt+pxLRPICNWMG4c8/3aDX2poDY3NYa KHcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=u6n4ZoE79ssHiyirvXFW8A+3su+zrfeaWMUO+ZcdGVY=; b=xjquZn0gnrTeqcq8aOv5IUBzHm1qOPYfBpXOM0wzj7tPbbIQG9aMTcNrM+Lwmlqm5o I8AFu4JFVHLPKD2GBr0x5LUmMw/uxHZ2auP+RCP33MYTO62/gtoY/FV3vPXS+B+qRD7J dn2hza/MM4hhzha8cJxmmGsLs/WHhJGop0tMEZEAVy4hmLCPRIJXV33gVcxWFPHbjlLF AyniSYZnkFy/HtjnyU4323Y5wGUkJG8JWJA8TzqzpLbJXthaKTykxWJsX//W9+ozUKxc cGs9sdqc2rDa6CYxtYoYHdJMK0pHui+YuPrsKnh7iWyzEBUZH8liFu9CRzgWRsF1KJN3 P9GA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j4si33675613pfr.272.2019.04.29.08.44.33; Mon, 29 Apr 2019 08:44:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728522AbfD2Poc (ORCPT + 99 others); Mon, 29 Apr 2019 11:44:32 -0400 Received: from mga14.intel.com ([192.55.52.115]:4157 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728438AbfD2Pob (ORCPT ); Mon, 29 Apr 2019 11:44:31 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Apr 2019 08:44:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,410,1549958400"; d="scan'208";a="319990394" Received: from silvixa00391824.ir.intel.com (HELO silvixa00391824.ger.corp.intel.com) ([10.237.222.24]) by orsmga005.jf.intel.com with ESMTP; 29 Apr 2019 08:44:30 -0700 From: Giovanni Cabiddu To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, Giovanni Cabiddu , Conor Mcloughlin , Sergey Portnoy Subject: [PATCH 7/7] crypto: qat - do not offload zero length requests Date: Mon, 29 Apr 2019 16:43:21 +0100 Message-Id: <20190429154321.21098-7-giovanni.cabiddu@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190429154321.21098-1-giovanni.cabiddu@intel.com> References: <20190429154321.21098-1-giovanni.cabiddu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org If a zero length request is submitted through the skcipher api, do not offload it and return success. Reviewed-by: Conor Mcloughlin Tested-by: Sergey Portnoy Signed-off-by: Giovanni Cabiddu --- drivers/crypto/qat/qat_common/qat_algs.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/qat/qat_common/qat_algs.c b/drivers/crypto/qat/qat_common/qat_algs.c index 868fefa9bb65..2842b2cdaa90 100644 --- a/drivers/crypto/qat/qat_common/qat_algs.c +++ b/drivers/crypto/qat/qat_common/qat_algs.c @@ -1058,6 +1058,9 @@ static int qat_alg_ablkcipher_encrypt(struct ablkcipher_request *req) struct device *dev = &GET_DEV(ctx->inst->accel_dev); int ret, ctr = 0; + if (req->nbytes == 0) + return 0; + qat_req->iv = dma_alloc_coherent(dev, AES_BLOCK_SIZE, &qat_req->iv_paddr, GFP_ATOMIC); if (!qat_req->iv) @@ -1115,6 +1118,9 @@ static int qat_alg_ablkcipher_decrypt(struct ablkcipher_request *req) struct device *dev = &GET_DEV(ctx->inst->accel_dev); int ret, ctr = 0; + if (req->nbytes == 0) + return 0; + qat_req->iv = dma_alloc_coherent(dev, AES_BLOCK_SIZE, &qat_req->iv_paddr, GFP_ATOMIC); if (!qat_req->iv) -- 2.20.1