Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Stephan Mueller <smueller@chronox.de>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: DRBG - add FIPS 140-2 CTRNG for noise source
Date:   Thu, 02 May 2019 14:49:40 +0200
Message-ID: <3628280.V02LyGYBHa@tauon.chronox.de>
In-Reply-To: <20190502124811.l4yozv4llqtdvozx@gondor.apana.org.au>
References: <1852500.fyBc0DU23F@positron.chronox.de> <20190502124811.l4yozv4llqtdvozx@gondor.apana.org.au>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

Am Donnerstag, 2. Mai 2019, 14:48:11 CEST schrieb Herbert Xu:

Hi Herbert,

> Hi Stephan:
>=20
> On Thu, May 02, 2019 at 02:40:51PM +0200, Stephan M=FCller wrote:
> > +static int drbg_fips_continuous_test(struct drbg_state *drbg,
> > +				     const unsigned char *entropy)
> > +{
> > +#ifdef CONFIG_CRYPTO_FIPS
>=20
> Please use the IS_ENABLED macro from linux/kconfig.h so that all
> of the code gets compiler coverage.

Will do.
>=20
> Thanks,


Ciao
Stephan