Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp7183332yba; Thu, 2 May 2019 05:50:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqzrXZHvgYutZHyqePtMp6Ev/GGgTXgftWgjCUWE2YqkUaFNjllWigLq6nB06oyyv83U9vSH X-Received: by 2002:a62:e10f:: with SMTP id q15mr4044627pfh.56.1556801436073; Thu, 02 May 2019 05:50:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556801436; cv=none; d=google.com; s=arc-20160816; b=jowffEujBsc76ZEP7nvGppNnqA7vfbd1/H1/g8KznGMdGLpqQ8kRfODMu4yTZ0IbSU 3PlqMFy8jU4KF0MmZFSdjpjd0Gvn5gctDx0kKwatt+dxeRTDp2KMvqj1rqZn0GZnFVqg UZvHdnqRlIDwlAnZqSY6KPPkENwOC9m+PoP3ivtqlyvWqw4qsX1X7W7jchbn4aQlAShO bemF/9Wa8ATzy+ncGNyxwj4Xdad4PM5XYE4csk2jyY57+7Es/d8nwxOK70rehZJLPZ1m cJifYciqDgN3gZzmVtxo1AioRn8PdCy/H0AA9VkHCKp7bHqrEjCgHEcnd7Re8qG0Kqhe QcNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Oo251kRFQXXF84TF52t01Vj4/5eH5YaWgKEcfSnJ6/I=; b=v5lnXKYFn6I7y1muSmznJS4ytRVxbX1p5KxTwtXZIL/50ly1r2yVvNDGbl0DOyZXr9 Jln08IATQo/17wB7pIOVgTCe0K2e/lm/qfkBDBYVBI+3ABFczCX04MCluT8J820IOf3q yff9NeJ5K4Br2GySQ0HcH30cdCgauBKfNWWJyWyQRU+OhySM9cPNdZrhaAKlI/wBrQhr PMIvIX2RtTzRBxh0OFGbDdj10H78MDCUT72dXseH0PGlhx+o7p1e1IJoFxFLP+qqH3/u sPU1/IiBYrXwSQ8xXv9TjeL0g45QK/DWlUhdzsZ8MjcRqngyLt+h5wUvEEpi0XKDU+9v Nclg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ce8si22642986plb.149.2019.05.02.05.50.22; Thu, 02 May 2019 05:50:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726404AbfEBMsS (ORCPT + 99 others); Thu, 2 May 2019 08:48:18 -0400 Received: from [5.180.42.13] ([5.180.42.13]:58200 "EHLO deadmen.hmeau.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1726324AbfEBMsR (ORCPT ); Thu, 2 May 2019 08:48:17 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hMB8I-0007Az-I6; Thu, 02 May 2019 20:48:14 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hMB8F-0006nS-UW; Thu, 02 May 2019 20:48:12 +0800 Date: Thu, 2 May 2019 20:48:11 +0800 From: Herbert Xu To: Stephan =?iso-8859-1?Q?M=FCller?= Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH] crypto: DRBG - add FIPS 140-2 CTRNG for noise source Message-ID: <20190502124811.l4yozv4llqtdvozx@gondor.apana.org.au> References: <1852500.fyBc0DU23F@positron.chronox.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1852500.fyBc0DU23F@positron.chronox.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Stephan: On Thu, May 02, 2019 at 02:40:51PM +0200, Stephan M?ller wrote: > > +static int drbg_fips_continuous_test(struct drbg_state *drbg, > + const unsigned char *entropy) > +{ > +#ifdef CONFIG_CRYPTO_FIPS Please use the IS_ENABLED macro from linux/kconfig.h so that all of the code gets compiler coverage. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt