Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 May 2019 14:05:24 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Horia =?utf-8?Q?Geant=C4=83?= <horia.geanta@nxp.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Vakul Garg <vakul.garg@nxp.com>,
        Franck Lenormand <franck.lenormand@nxp.com>,
        Iuliana Prodan <iuliana.prodan@nxp.com>,
        Marcin Niestroj <m.niestroj@grinn-global.com>,
        linux-crypto@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH 3/7] crypto: caam - convert top level drivers to libraries
Message-ID: <20190503060524.kyc3ktst5k3hu2kb@gondor.apana.org.au>
References: <20190425162501.4565-1-horia.geanta@nxp.com>
 <20190425162501.4565-4-horia.geanta@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190425162501.4565-4-horia.geanta@nxp.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 25, 2019 at 07:24:57PM +0300, Horia Geantă wrote:
>
> @@ -3511,43 +3511,17 @@ static void caam_aead_alg_init(struct caam_aead_alg *t_alg)
>  	alg->exit = caam_aead_exit;
>  }
>  
> -static int __init caam_algapi_init(void)
> +int caam_algapi_init(struct device *ctrldev)
>  {
>  	struct device_node *dev_node;
>  	struct platform_device *pdev;
> -	struct caam_drv_private *priv;
> +	struct caam_drv_private *priv = dev_get_drvdata(ctrldev);
>  	int i = 0, err = 0;
>  	u32 aes_vid, aes_inst, des_inst, md_vid, md_inst, ccha_inst, ptha_inst;
>  	u32 arc4_inst;
>  	unsigned int md_limit = SHA512_DIGEST_SIZE;
>  	bool registered = false, gcm_support;
>  
> -	dev_node = of_find_compatible_node(NULL, NULL, "fsl,sec-v4.0");
> -	if (!dev_node) {
> -		dev_node = of_find_compatible_node(NULL, NULL, "fsl,sec4.0");
> -		if (!dev_node)
> -			return -ENODEV;
> -	}
> -
> -	pdev = of_find_device_by_node(dev_node);
> -	if (!pdev) {
> -		of_node_put(dev_node);
> -		return -ENODEV;
> -	}
> -
> -	priv = dev_get_drvdata(&pdev->dev);
> -	of_node_put(dev_node);
> -
> -	/*
> -	 * If priv is NULL, it's probably because the caam driver wasn't
> -	 * properly initialized (e.g. RNG4 init failed). Thus, bail out here.
> -	 */
> -	if (!priv) {
> -		err = -ENODEV;
> -		goto out_put_dev;
> -	}
> -
> -
>  	/*
>  	 * Register crypto algorithms the device supports.
>  	 * First, detect presence and attributes of DES, AES, and MD blocks.

This introduces two new warnings regarding unused variables.  Please
fix and resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt