Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     "David S. Miller" <davem@davemloft.net>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Vakul Garg <vakul.garg@nxp.com>,
        Franck Lenormand <franck.lenormand@nxp.com>,
        Iuliana Prodan <iuliana.prodan@nxp.com>,
        Marcin Niestroj <m.niestroj@grinn-global.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 3/7] crypto: caam - convert top level drivers to libraries
Thread-Topic: [PATCH 3/7] crypto: caam - convert top level drivers to
 libraries
Thread-Index: AQHU+4N5g9H/2PNb1ESwjP342qcqNw==
Date:   Fri, 3 May 2019 13:25:17 +0000
Message-ID: <VI1PR0402MB34859CC7D78081E33A4BA24498350@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <20190425162501.4565-1-horia.geanta@nxp.com>
 <20190425162501.4565-4-horia.geanta@nxp.com>
 <20190503060524.kyc3ktst5k3hu2kb@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d1caaa9-209b-4df5-bb40-08d6cfcac869
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2019 13:25:17.0378
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3375
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 5/3/2019 4:08 PM, Herbert Xu wrote:=0A=
> On Thu, Apr 25, 2019 at 07:24:57PM +0300, Horia Geant=E3 wrote:=0A=
>>=0A=
>> @@ -3511,43 +3511,17 @@ static void caam_aead_alg_init(struct caam_aead_=
alg *t_alg)=0A=
>>  	alg->exit =3D caam_aead_exit;=0A=
>>  }=0A=
>>  =0A=
>> -static int __init caam_algapi_init(void)=0A=
>> +int caam_algapi_init(struct device *ctrldev)=0A=
>>  {=0A=
>>  	struct device_node *dev_node;=0A=
>>  	struct platform_device *pdev;=0A=
>> -	struct caam_drv_private *priv;=0A=
>> +	struct caam_drv_private *priv =3D dev_get_drvdata(ctrldev);=0A=
>>  	int i =3D 0, err =3D 0;=0A=
>>  	u32 aes_vid, aes_inst, des_inst, md_vid, md_inst, ccha_inst, ptha_inst=
;=0A=
>>  	u32 arc4_inst;=0A=
>>  	unsigned int md_limit =3D SHA512_DIGEST_SIZE;=0A=
>>  	bool registered =3D false, gcm_support;=0A=
>>  =0A=
>> -	dev_node =3D of_find_compatible_node(NULL, NULL, "fsl,sec-v4.0");=0A=
>> -	if (!dev_node) {=0A=
>> -		dev_node =3D of_find_compatible_node(NULL, NULL, "fsl,sec4.0");=0A=
>> -		if (!dev_node)=0A=
>> -			return -ENODEV;=0A=
>> -	}=0A=
>> -=0A=
>> -	pdev =3D of_find_device_by_node(dev_node);=0A=
>> -	if (!pdev) {=0A=
>> -		of_node_put(dev_node);=0A=
>> -		return -ENODEV;=0A=
>> -	}=0A=
>> -=0A=
>> -	priv =3D dev_get_drvdata(&pdev->dev);=0A=
>> -	of_node_put(dev_node);=0A=
>> -=0A=
>> -	/*=0A=
>> -	 * If priv is NULL, it's probably because the caam driver wasn't=0A=
>> -	 * properly initialized (e.g. RNG4 init failed). Thus, bail out here.=
=0A=
>> -	 */=0A=
>> -	if (!priv) {=0A=
>> -		err =3D -ENODEV;=0A=
>> -		goto out_put_dev;=0A=
>> -	}=0A=
>> -=0A=
>> -=0A=
>>  	/*=0A=
>>  	 * Register crypto algorithms the device supports.=0A=
>>  	 * First, detect presence and attributes of DES, AES, and MD blocks.=
=0A=
> =0A=
> This introduces two new warnings regarding unused variables.  Please=0A=
> fix and resubmit.=0A=
> =0A=
Ouch.=0A=
This is due to developing on linux-next followed by incorrect merge conflic=
t=0A=
resolution when moving to cryptodev-2.6 tree.=0A=
Will resubmit.=0A=
=0A=
Thanks,=0A=
Horia=0A=