Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <b6332dfac8da2dc6a11eeda9e4d0fba44d21509e.camel@opteya.com>
From:   Yann Droneaud <ydroneaud@opteya.com>
To:     Stephan =?ISO-8859-1?Q?M=FCller?= <smueller@chronox.de>,
        Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-crypto@vger.kernel.org
Date:   Tue, 07 May 2019 10:19:38 +0200
In-Reply-To: <1978979.Zxv6YQyJUk@positron.chronox.de>
References: <1852500.fyBc0DU23F@positron.chronox.de>
         <5352150.0CmBXKFm2E@positron.chronox.de>
         <20190503014241.cy35pjinezhapga7@gondor.apana.org.au>
         <1978979.Zxv6YQyJUk@positron.chronox.de>
Organization: OPTEYA
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.32.1 (3.32.1-1.fc30) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH v4] crypto: DRBG - add FIPS 140-2 CTRNG for noise source
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

Hi

Le vendredi 03 mai 2019 à 21:58 +0200, Stephan Müller a écrit :
> 
> FIPS 140-2 section 4.9.2 requires a continuous self test of the noise
> source. Up to kernel 4.8 drivers/char/random.c provided this continuous
> self test. Afterwards it was moved to a location that is inconsistent
> with the FIPS 140-2 requirements.
> 

Could you list the commit that move the self test and add that
information in the commit message.

> Thus, the FIPS 140-2 CTRNG is added to the DRBG when it obtains the
> seed. This patch resurrects the function drbg_fips_continous_test that
> existed some time ago and applies it to the noise sources.
> 

Please identify the commit it was resurrected from, for traceability
purpose.

Regards.

-- 
Yann Droneaud
OPTEYA