Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Kalyani Akula <kalyania@xilinx.com>
To:     Stephan Mueller <smueller@chronox.de>
CC:     "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sarat Chand Savitala <saratcha@xilinx.com>
Subject: RE: [RFC PATCH 4/5] crypto: Adds user space interface for
 ALG_SET_KEY_TYPE
Thread-Topic: [RFC PATCH 4/5] crypto: Adds user space interface for
 ALG_SET_KEY_TYPE
Thread-Index: AQHUrjLRC0KQY4vUUEiutylzuXEA7qWzVM+AgJUjQyCAA8MlgIAVaNiQ
Date:   Wed, 8 May 2019 09:31:08 +0000
Message-ID: <SN6PR02MB5135CE53C3E3FB34CA5E6BA8AF320@SN6PR02MB5135.namprd02.prod.outlook.com>
References: <1547708541-23730-1-git-send-email-kalyani.akula@xilinx.com>
 <4735882.YQOrfzxm5S@tauon.chronox.de>
 <BN7PR02MB5124AC0C75B15E5FB66DF2B6AF220@BN7PR02MB5124.namprd02.prod.outlook.com>
 <18759853.IUaQuE38eh@tauon.chronox.de>
In-Reply-To: <18759853.IUaQuE38eh@tauon.chronox.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 23aae62e-b2ff-4387-c1ec-08d6d397e72f
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2019 09:31:08.9611
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB4175
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi Stephan,

Keyrings is in-kernel key-management and retention facility. User can use i=
t to manage keys used for applications.=20

Xilinx cryptographic hardware has a mechanism to store keys in its internal=
 hardware and do not have mechanism to read it back due to security reasons=
.=20
It stores key internally in different forms like simple key, key encrypted =
with unique hardware DNA, key encrypted with hardware family key,=20
key stored in eFUSEs/BBRAM etc.=20
Based on security level expected, user can select one of the key for AES op=
eration. Since AES hardware internally has access to these keys,=20
user do not require to provide key to hardware, but need to tell which inte=
rnal hardware key user application like to use for AES operation.=20

Basic need is to pass information to AES hardware about which internal hard=
ware key to be used for AES operation.=20

I agree that from general use case perspective we are not selecting key typ=
e but selecting internal hardware keys provided by user.=20
How about providing option to select custom hardware keys provided by hardw=
are (AES_SEL_HW_KEY)?

Thanks
kalyani

> -----Original Message-----
> From: Stephan Mueller <smueller@chronox.de>
> Sent: Thursday, April 25, 2019 12:01 AM
> To: Kalyani Akula <kalyania@xilinx.com>
> Cc: herbert@gondor.apana.org.au; davem@davemloft.net; linux-
> crypto@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [RFC PATCH 4/5] crypto: Adds user space interface for
> ALG_SET_KEY_TYPE
>=20
> Am Montag, 22. April 2019, 11:17:55 CEST schrieb Kalyani Akula:
>=20
> Hi Kalyani,
>=20
> > > Besides, seem to be more a key handling issue. Wouldn't it make
> > > sense to rather have such issue solved with key rings than in the
> > > kernel crypto API?
> >
> > [kalyani] Can you please elaborate on this further ?
>=20
> The kernel has a keyring support in security/keys which has a user space
> interface with keyutils. That interface is commonly used for any sort of =
key
> manipulation.
>=20
> Ciao
> Stephan
>=20