Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp266977yba; Wed, 8 May 2019 20:17:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqwKLfxTHLfiR8rdrNpGk278QK/JcHY0YcCcwdEgha5m+dlmyJ07w+NM0jTNe0jozApfwQez X-Received: by 2002:aa7:99dd:: with SMTP id v29mr1904726pfi.252.1557371821249; Wed, 08 May 2019 20:17:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557371821; cv=none; d=google.com; s=arc-20160816; b=KbmCROyvN+AWFodYP10+kmRrby5C9/kJFqKeXNjv4fgbAO/eZozlzNCV4fBCtggW+7 tfbkjAobn7ZZ9BKnfl1Poo02FOcHPNOmkwHx5uqwuEfSz3YDZgQO3PwppugTQQiIV4T6 CU5mzT25J7d4uIVcFDzf5/f469pkIkd1RcdZaQvs9EhdW6V8XnulbfxKI+zLadecD4eA 9hcr9DfBJnR4mQ8ScbsxxuwLObxL/aKtCbl0GKlgIrM2J0gO87dTSRrmnskyjkcDGLxE cMcMWIpcE4Z/pX2BTo2CCj7ORJt7HuS/q1GV/F5K+hYCEOJehrdKyqD1oexTKfULkbSj UeJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=PUbwYGHS39HB2xUeWsOVZgcOpcJs7Mf1+/XLtfjHGb4=; b=hosI81mFB2yidYYse/MG0hy8ver6YG9QhLWrTCrJXeA3NZ2v12aOSFXTIMz9/pEmQ0 gNiTxxSw0Ic3U5LcNwRcyLDjYNEINr1A9lQGe/h89V/y4sVCSMLPja5879epT5tu/IEK jhO/kH8H00cvANlfpZhh8AfndkuU0C3pX3tjDYdrYFcfGXeodThN/nhDrvqUxWxrjKwt nDcpwRzGNFNXLsx1ZzpN9AJEWieKC447+iMf1MYWNfzggV+PfeygeR7J531HcQ9wQBlU IpoKOVHCmWo75as6fqiwXTCM3iigDn8pRoihHVRxu4B4g4fUnDHoKe6DjgGddIa78CLG XoCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v3si1423354pgi.171.2019.05.08.20.16.46; Wed, 08 May 2019 20:17:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726460AbfEIDQj (ORCPT + 99 others); Wed, 8 May 2019 23:16:39 -0400 Received: from [5.180.42.13] ([5.180.42.13]:52918 "EHLO deadmen.hmeau.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1726251AbfEIDQj (ORCPT ); Wed, 8 May 2019 23:16:39 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hOZXp-00005y-4k; Thu, 09 May 2019 11:16:29 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hOZXl-00086W-RE; Thu, 09 May 2019 11:16:25 +0800 Date: Thu, 9 May 2019 11:16:25 +0800 From: Herbert Xu To: Joao Moreira Cc: Eric Biggers , Kees Cook , Ingo Molnar , Thomas Gleixner , Borislav Petkov , X86 ML , linux-crypto , LKML , Kernel Hardening Subject: Re: [PATCH v3 0/7] crypto: x86: Fix indirect function call casts Message-ID: <20190509031625.f6usxmqzfehrmx7r@gondor.apana.org.au> References: <20190507161321.34611-1-keescook@chromium.org> <20190507170039.GB1399@sol.localdomain> <20190507215045.GA7528@sol.localdomain> <20190508133606.nsrzthbad5kynavp@gondor.apana.org.au> <20190509020439.GB693@sol.localdomain> <8c9a53b9-12e6-3380-21c8-4fe85342f0ac@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c9a53b9-12e6-3380-21c8-4fe85342f0ac@suse.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, May 09, 2019 at 12:12:54AM -0300, Joao Moreira wrote: > > This is how things were done in the original patch set, but some concerns > were raised about this approach: > > https://lkml.org/lkml/2018/4/16/74 No that's not what I'm suggesting at all. Just get rid of those wrapper functions and change the underlying asm functions to take a void *. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt