Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp972571yba; Thu, 9 May 2019 08:43:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxyfwtbttAUOQ42M4dBgpjOhpiKAhmDmCkCQO+YZEw0Z05zor2lXlqvXercN+1utGIGNemt X-Received: by 2002:a62:4690:: with SMTP id o16mr6184287pfi.166.1557416602994; Thu, 09 May 2019 08:43:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557416602; cv=none; d=google.com; s=arc-20160816; b=yqSlA/2/eZ3QqM1O1aE99AbLMdqFfdxuMKwTO4es1zdV+5rsbdULg27/QU7hpX9qvH /7F0cE56GDKc8gyfC2AXF5b8AitAChgUscxIe9VgELPr7ES7aKw6EF1cu0KfewV9bdMk We1XH3soQVJItyUZHPhkbCeOQsaTklZOFMz34+5sbNI/8iWllZOb2Qw7UCW7g7FwP7Rk l0Q0lAGEjxr7gbcpo3gcnqF/408dd81+f2dvv3MId1mzAIIFiY/EIviTdgBiqWXGqnFE LqhVYo8q3s+hMAir0xxadzcyivtXesFR1o/+UZpqpz1VKkMWY02wsnwrbblAFokkG4oR spgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:cc:to:from:subject; bh=7n6yP7j0zSrR8yCJf2xAtXj8RKcafPDpI+xylwwc2Tg=; b=nad4HpDlHCQOcu/YE+ocoIcB54C1Npzfvee7OV9mkh9ZhCU4qCSfkVQOkkUhkW9nLB Q527CFK/gSUvNpHjfDS21L4bj/dakdAsrt/NTIh881tKKVciKv6as0TId11OwRXsRi3w 1ZnmKsJNWpj7wMumtQsrtPCWFqAgIeCVntBxHFQym+4ipHdiw7qLPLpNheywAFjBLdi7 Rn3ax3I6mi1I6BfeMVp445vi7m2LzwavyciqCqhMu5zILEyet1vclOADsnQj8lF0ke7Y utaGwA3DUBlLrEGeJa9q90Tvvw+aTnrwjdDfXEmPI46ru/XJKd6zA7/jJR0awpexSSEM pO5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 76si3872815pgf.582.2019.05.09.08.43.07; Thu, 09 May 2019 08:43:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbfEIPmr (ORCPT + 99 others); Thu, 9 May 2019 11:42:47 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48476 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726714AbfEIPmq (ORCPT ); Thu, 9 May 2019 11:42:46 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x49FccF4023474 for ; Thu, 9 May 2019 11:42:45 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2scn6b66gd-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 09 May 2019 11:42:45 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 9 May 2019 16:42:43 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 9 May 2019 16:42:38 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x49FgbQx49676444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 May 2019 15:42:37 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3837942041; Thu, 9 May 2019 15:42:37 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2B74B4204D; Thu, 9 May 2019 15:42:35 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.95.107]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 9 May 2019 15:42:35 +0000 (GMT) Subject: Re: [PATCH v10 03/12] PKCS#7: Introduce pkcs7_get_digest() From: Mimi Zohar To: Thiago Jung Bauermann , linux-integrity@vger.kernel.org Cc: linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , David Howells , David Woodhouse , Jessica Yu , Herbert Xu , "David S. Miller" , Jonathan Corbet , "AKASHI, Takahiro" Date: Thu, 09 May 2019 11:42:13 -0400 In-Reply-To: <20190418035120.2354-4-bauerman@linux.ibm.com> References: <20190418035120.2354-1-bauerman@linux.ibm.com> <20190418035120.2354-4-bauerman@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19050915-0012-0000-0000-00000319FC6E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19050915-0013-0000-0000-0000215283C6 Message-Id: <1557416533.10635.63.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-09_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905090090 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, 2019-04-18 at 00:51 -0300, Thiago Jung Bauermann wrote: > IMA will need to access the digest of the PKCS7 message (as calculated by > the kernel) before the signature is verified, so introduce > pkcs7_get_digest() for that purpose. > > Also, modify pkcs7_digest() to detect when the digest was already > calculated so that it doesn't have to do redundant work. Verifying that > sinfo->sig->digest isn't NULL is sufficient because both places which > allocate sinfo->sig (pkcs7_parse_message() and pkcs7_note_signed_info()) > use kzalloc() so sig->digest is always initialized to zero. > > Signed-off-by: Thiago Jung Bauermann > Cc: David Howells > Cc: Herbert Xu > Cc: "David S. Miller" Reviewed-by: Mimi Zohar