Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1740090yba; Thu, 9 May 2019 23:41:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqxsZIlafspoFjexaT7A0JgikCoDZ1Ie42M1IUxyRGsNHdQkoagBB9oM8i+tyCcKwfTC5u0s X-Received: by 2002:a63:4710:: with SMTP id u16mr656278pga.447.1557470466671; Thu, 09 May 2019 23:41:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557470466; cv=none; d=google.com; s=arc-20160816; b=x9e02NVHgeZRwwzflub1X00UteiWvkYctHTOtMW7DbHdT607TtjmonhCkY/cRPp+LK tuMhrD+f0b1vQVNVuBp+1RYHlcxnTb8s+0G6pQ9qohNH7CHhzYjClQKKGgCb9qdUCiOX vIcaoFdy7qPRIJs8roXuN0EPc5T+4ELdyK8c1ffiyEnlEzAMNTpiF+5h+obTqOayvjUQ GYg2es+Febvtfve8RWr0PhgQg4L45nBN4buW2R7SSqOoB1LAI0af7gVCviVbPEdXRmHD wINK+Pf8hiVkMhAO7jUcXFCrq6qEtV1cAz1ci7KCQ+ivihxhov4m3npdLx1wDEX2ZPiy P7rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=VXoyhIPVdaB5SBHi5t8hgoAXfVmDLIbB3whJtJ4Xx44=; b=uuEjL9liqBE97aU2nFayPfZmcMtj/G8soJbnAphznkevR6hcYVe68LVzHKx+iQBGuz qrD24gxYo5pmBIOTP9Wn3kFmPeFMuezwC2avdjbxXWej1Yg+MJ1CNZZCr5utZpRXPz3+ GxMuieaU1vfKUdcmjdktyzK+tTSpFXCUWuv5wFXdhC0WalE0beNBsJl+RQSbRquX7L5N 6lsuyTxR0aMWNXg+F/q6E2NXyYp1AgPBXC+KnUDNmx4RojvJlxHb38B23MYLBR22uAgF 4lYwyg4WqK+DMqNQOooDP+znRApd02pFwi6wUM1YDrAyDp501GlJPVWun9Nlv1Qm7UdZ nWGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s2si6187427pgp.69.2019.05.09.23.40.42; Thu, 09 May 2019 23:41:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726995AbfEJGkF (ORCPT + 99 others); Fri, 10 May 2019 02:40:05 -0400 Received: from orcrist.hmeau.com ([5.180.42.13]:34110 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726940AbfEJGkF (ORCPT ); Fri, 10 May 2019 02:40:05 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hOzBj-0001Lo-Ph; Fri, 10 May 2019 14:39:23 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hOzBb-0004u3-V0; Fri, 10 May 2019 14:39:16 +0800 Date: Fri, 10 May 2019 14:39:15 +0800 From: Herbert Xu To: Neal Liu Cc: Stephan Mueller , mpm@selenic.com, robh+dt@kernel.org, mark.rutland@arm.com, matthias.bgg@gmail.com, wsd_upstream@mediatek.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Crystal.Guo@mediatek.com Subject: Re: [PATCH 3/3] hwrng: add mt67xx-rng driver Message-ID: <20190510063915.kwqy3e5urs6j7ity@gondor.apana.org.au> References: <1557287937-2410-1-git-send-email-neal.liu@mediatek.com> <1557287937-2410-4-git-send-email-neal.liu@mediatek.com> <12193108.aNnqf5ydOJ@tauon.chronox.de> <1557311737.11818.11.camel@mtkswgap22> <20190509052649.xfkgb3qd7rhcgktj@gondor.apana.org.au> <1557413686.23445.6.camel@mtkswgap22> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1557413686.23445.6.camel@mtkswgap22> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, May 09, 2019 at 10:54:46PM +0800, Neal Liu wrote: > > Hi Stephan/Herbert, > My mistake. This buffer is allocated by kmalloc with larger than 32 > bytes. So yes, it's word-align for sure. > reference: > https://elixir.bootlin.com/linux/latest/source/drivers/char/hw_random/core.c#L590 Yes you're right. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt