Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1492048yba; Thu, 16 May 2019 23:28:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqxfbj+ZJs5Q7tywuJp6VezXyEYzbGOz4Ugy+rOD+dIbCnXWHFzmvOO6T8gCOBAs0+Rj9eDF X-Received: by 2002:a63:fa16:: with SMTP id y22mr15165444pgh.15.1558074491644; Thu, 16 May 2019 23:28:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558074491; cv=none; d=google.com; s=arc-20160816; b=DVFkU08S7RVcJ17hrCMxg6XaPjHY5OozR1AM/1Z3snAGJG/YTpW7yu48XNxXpvdDcx N3DU+DMivjEAksZdsXmEaEOVbTsI1w5O0g6AIUr5AXoVJNu/C8/NrACwp8S+64B6hQ+v /GNcL7M68TKk3ajnzy1NtVDq+sO12ArtqMXcNoSM9G6HCyas9F+QS40YbayiLY33mmiu tPre4/QEq5S+FR9DbNMO2QD0E+1eSPJMVYSVG84g7C8Ih4l9c1t1ErKJd0VwTS4JX4BG ZP0Er7+Oi989JRmwNTtg9U6l/oLmBE4kQ50uLuVTSodmB34AZwoMDAq5igGnSd4d7sJb 81Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=fxkJdwOFopavm+ZyUxZ4encVoL+uCEP5Lo0ZQ76BADI=; b=ReTtGcWU9RbEfKkhViJ2hPD8L2KQNBeEoUMjVeZdqmlp5uA2DJ/a2j/0fQBoDyuYC+ bGoT3k39sPjfmCplRa71ga2Hz52oejdN5bPN4m3sS5++pXStofGOLW7SpjlYcqUCTLFz Fxv+meuIdrJgb6NUhNLtrAuryEGwYtIOuh79KtC8Zi7RVmpKwl8fJunl13ZjQoOrTmIv fh5DC7A+FFrvdrKM+kYLYdjE02RTgB6wFxNTebNvevp78emO2f5cSCqi5gvnA9GfMwha vlTMZyNLzD72SQgfnJUkGw6UqTRNr5LZEZnPpBytnod1+GSq5qIT00QqlHIMkQMebcWe 5wtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=CTAbbyiT; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f90si7356252plb.25.2019.05.16.23.27.47; Thu, 16 May 2019 23:28:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=CTAbbyiT; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727500AbfEQGLN (ORCPT + 99 others); Fri, 17 May 2019 02:11:13 -0400 Received: from mail-eopbgr80040.outbound.protection.outlook.com ([40.107.8.40]:39413 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727106AbfEQGLM (ORCPT ); Fri, 17 May 2019 02:11:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fxkJdwOFopavm+ZyUxZ4encVoL+uCEP5Lo0ZQ76BADI=; b=CTAbbyiT5cCI7DKkCgtiMtQ4L1KgY8Ev/fJSWcZH0ooXHzdPtAphvbv4q/+6Z+LRGINrlWTYvvf8Ys8TP0d2lsqZTwbieC7m4wsZVh1jpxaqKq096UJp7bb78Po15loXK8d4xiUmyDvbWdpwrHKnn9Nr+JoRAdeQ5pAtG1Slqw0= Received: from VI1PR0402MB3485.eurprd04.prod.outlook.com (52.134.3.153) by VI1PR0402MB3373.eurprd04.prod.outlook.com (52.134.1.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.16; Fri, 17 May 2019 06:11:09 +0000 Received: from VI1PR0402MB3485.eurprd04.prod.outlook.com ([fe80::a450:3c13:d7af:7451]) by VI1PR0402MB3485.eurprd04.prod.outlook.com ([fe80::a450:3c13:d7af:7451%3]) with mapi id 15.20.1900.010; Fri, 17 May 2019 06:11:09 +0000 From: Horia Geanta To: Sascha Hauer , "linux-crypto@vger.kernel.org" CC: "kernel@pengutronix.de" Subject: Re: [PATCH] crypto: caam: print debugging hex dumps after unmapping Thread-Topic: [PATCH] crypto: caam: print debugging hex dumps after unmapping Thread-Index: AQHVDHdRrXIrKim4f0WfWBBm7eUFjw== Date: Fri, 17 May 2019 06:11:09 +0000 Message-ID: References: <20190516142442.32537-1-s.hauer@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=horia.geanta@nxp.com; x-originating-ip: [212.146.100.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e065a260-9229-4726-cfd5-08d6da8e7498 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:VI1PR0402MB3373; x-ms-traffictypediagnostic: VI1PR0402MB3373: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0040126723 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(346002)(39860400002)(376002)(366004)(396003)(189003)(199004)(5660300002)(446003)(74316002)(53546011)(66946007)(66556008)(64756008)(66476007)(486006)(66446008)(76116006)(6436002)(476003)(73956011)(25786009)(33656002)(6506007)(52536014)(2501003)(110136005)(102836004)(66066001)(26005)(186003)(6116002)(229853002)(99286004)(316002)(7696005)(7736002)(86362001)(305945005)(71190400001)(4326008)(53936002)(81166006)(8936002)(3846002)(6246003)(44832011)(68736007)(4744005)(14454004)(55016002)(2906002)(256004)(478600001)(76176011)(9686003)(8676002)(81156014)(71200400001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0402MB3373;H:VI1PR0402MB3485.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: KuyKA0JH6MnfxhOHT2nvMVjeaNWrdujslV3kH+epVwzGsuu+iqeh0WzS4JOfN29S/G7ofW4qDTJ0D2J92gcWvP6/sOaPFq4Se/9kbgrKKeDHLpwES+fcYrCAZ2PrCK5WujHHH38FscXVfN2mNfByDLwPOKnwAOQ9eo1OlcfUlEr+fBgEYZp3kAdFuKosMAbkGwuFtmWjHNshhZp8cgORLp5r+wjsT17PEQIB0x5DlB2U6tYce30DNmxthlHpufk3DCd/HEBkR/0OcoIaMjNM7C8XbPZi7oiCfXO4kg56DFRusFoT8dAwihj6hCBVBrSrNtmY6GNj/cVvfR7Fb5BDw1mgDV9Rrba6+J2Onld+VpRXMdeGeuQ+6gJNG8Vp8mqXP7J/Ij+IEWYzx11yMtQM2CbjCqCiz7+92eLQnQ7jZeM= Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e065a260-9229-4726-cfd5-08d6da8e7498 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2019 06:11:09.4797 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3373 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 5/16/2019 5:24 PM, Sascha Hauer wrote:=0A= > For encryption the destination pointer was still mapped, so the hex dump= =0A= > may be wrong. The IV still contained the input IV while printing instead= =0A= > of the output IV as intended.=0A= > =0A= > For decryption the destination pointer was still mapped, so the hex dump= =0A= > may be wrong. The IV dump was correct.=0A= > =0A= > Do the hex dumps consistenly after the buffers have been unmapped and=0A= > in case of IV copied to their final destination.=0A= > =0A= > Signed-off-by: Sascha Hauer =0A= Reviewed-by: Horia Geant=E3 =0A= =0A= Thanks,=0A= Horia=0A=