Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp77752yba; Mon, 20 May 2019 05:19:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqzXv/ZUkan3GRsO/lbON5PhHFj9ncUyBkkmNnaAUVx4RC/Z3T7Tf/VhJNQPutBiMEEMNj+0 X-Received: by 2002:a65:6559:: with SMTP id a25mr51213074pgw.33.1558354743366; Mon, 20 May 2019 05:19:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558354743; cv=none; d=google.com; s=arc-20160816; b=gksaEXSV72jXtPCl1EcrFCSJ5K6rskzpsYvbhuj8IJpDqbrPYeu07rc6xO75RYEifd RHGR2EcxJSGF2EKFByouxl6yQbLnNcOH6jlbBZDLmdIQgxex/sTvr7HGx4llSzfAIXoY cAIud0u2VAjRZn5v9rIAhOUYhVVrXpuxvQMAB0+rxc7pNaN5ikRWsuNjRWqWASIUk10l LuwKsyQ1qks6Gh3sILDNwlqx70FW96uKm2b/v/iHrwS+ZlISimJ7vVEnb22T2d4RKyFH 1Bj1VEigYS3eCkTiB+1wxRT0W/Zmb8O+KtrLSadfCw4qfsFK9me2g8yVak2Qp8rk2Ms5 jgew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pOu5YrQqs+M+lxPCgASTUnXoYKsjjMSUYUbzYy08b6w=; b=roloiufxEjjk5uf5JlhFP24Emhb4AXv5S7TKFjLB1IRl3XWll+Xug2y4TQTC11puhh hASE/uhF3fPkIDhGN0w7YOiCV3DgdRSjIVC9C65QbZ7qLW76wckQ9D2SP2glGO+aNOYa NKwhykWV28v7VHCLPTXkvdFLxxe4+O96VguQuL9rAG6g1wNKQIi4I/fluPz0CxGxwu0r 8SpV5QMYp5Hr7jgpHAHQ9hqBHdP0Y6CCGn99BHYF4Dfvt0ZAUepa91LKXYRFRuiP9VMl rnMqEKE6Ha+nkilY2Lg0pOJPduvdfNejKpV8QklXwcOlGIuC+39OQaKHjXQUkrK9DRpD TCMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JU7536XV; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si13646644plk.233.2019.05.20.05.18.49; Mon, 20 May 2019 05:19:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JU7536XV; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732532AbfETMJG (ORCPT + 99 others); Mon, 20 May 2019 08:09:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:54804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730921AbfETMJG (ORCPT ); Mon, 20 May 2019 08:09:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A04A20656; Mon, 20 May 2019 12:09:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558354145; bh=wZbHqJjzSCtRrw1EnIKg8CMFLMhBazKLa0vRuT7Cyv4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JU7536XVe6T/VGeJ+j7c7M0xeRuruJCV7FOA+wbNKM/UUluggkO5lRNP8o00D/5mJ S7GIPNbAacX0h6TA67hr3NFAJshjXNqlRYiOJzcH2OBMIwWWKhdV6CMYVqfKhuEqCX vMOGx72sZZKwXC+X5RwqFfLjutGNpeecqZ6XGhfE= Date: Mon, 20 May 2019 14:09:03 +0200 From: Greg KH To: Gilad Ben-Yossef Cc: Herbert Xu , "David S. Miller" , stable@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [STABLE PATCH 1/2] crypto: ccree: zap entire sg on aead request unmap Message-ID: <20190520120903.GB13524@kroah.com> References: <20190520115025.16457-1-gilad@benyossef.com> <20190520115025.16457-2-gilad@benyossef.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190520115025.16457-2-gilad@benyossef.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, May 20, 2019 at 02:50:23PM +0300, Gilad Ben-Yossef wrote: > We were trying to be clever zapping out of the cache only the required > length out of scatter list on AEAD request completion and getting it > wrong. > > As Knuth said: "when in douby, use brute force". Zap the whole length of > the scatter list. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/crypto/ccree/cc_buffer_mgr.c | 18 ++---------------- > 1 file changed, 2 insertions(+), 16 deletions(-) This does not apply on top of my latest 4.19 tree with the current pending queue applied, nor does it apply to 5.1 or 5.0. How about waiting a few days and resending after I do the next round of stable updates, so you can rebase on top of them easier? thanks, greg k-h