Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Sascha Hauer <s.hauer@pengutronix.de>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
CC:     "kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH 2/3] crypto: caam: print debug messages at debug level
Thread-Topic: [PATCH 2/3] crypto: caam: print debug messages at debug level
Thread-Index: AQHVDJL8mmT01przhESHS2q17fhpQg==
Date:   Tue, 21 May 2019 14:18:16 +0000
Message-ID: <VI1PR0402MB34858BA974ECCBF303931CC198070@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <20190517092905.1264-1-s.hauer@pengutronix.de>
 <20190517092905.1264-3-s.hauer@pengutronix.de>
 <20190517095018.7qcufwb77nu3owb4@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 124777c3-a56a-4f1a-8abf-08d6ddf72afc
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2019 14:18:16.6378
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3725
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 5/17/2019 12:50 PM, Sascha Hauer wrote:=0A=
> On Fri, May 17, 2019 at 11:29:04AM +0200, Sascha Hauer wrote:=0A=
>> The CAAM driver used to put its debug messages inside #ifdef DEBUG and=
=0A=
>> then prints the messages at KERN_ERR level. Replace this with proper=0A=
>> functions printing at KERN_DEBUG level. The #ifdef DEBUG gets=0A=
>> unnecessary when the right functions are used.=0A=
>>=0A=
>> This replaces:=0A=
>>=0A=
>> - print_hex_dump(KERN_ERR ...) inside #ifdef DEBUG with=0A=
>>   print_hex_dump_debug(...)=0A=
>> - dev_err() inside #ifdef DEBUG with dev_dbg()=0A=
>> - printk(KERN_ERR ...) inside #ifdef DEBUG with dev_dbg()=0A=
>>=0A=
>> Some parts of the driver use these functions already, so it is only=0A=
>> consequent to use the debug function consistently.=0A=
>>=0A=
>> @@ -993,20 +978,17 @@ static void skcipher_encrypt_done(struct device *j=
rdev, u32 *desc, u32 err,=0A=
>>  	struct crypto_skcipher *skcipher =3D crypto_skcipher_reqtfm(req);=0A=
>>  	int ivsize =3D crypto_skcipher_ivsize(skcipher);=0A=
>>  =0A=
>> -#ifdef DEBUG=0A=
>> -	print_hex_dump(KERN_ERR, "dstiv  @"__stringify(__LINE__)": ",=0A=
>> +	print_hex_dump_debug("dstiv  @"__stringify(__LINE__)": ",=0A=
>>  		       DUMP_PREFIX_ADDRESS, 16, 4, req->iv,=0A=
>>  		       edesc->src_nents > 1 ? 100 : ivsize, 1);=0A=
>> -#endif=0A=
>> +=0A=
> =0A=
> I just realized that this print_hex_dump_debug() needs to be inside if (i=
vsize)=0A=
> because since eaed71a44ad9 ("crypto: caam - add ecb(*) support") req->iv=
=0A=
> can be NULL. This is broken with or without this patch, I can include a=
=0A=
> patch fixing this up when doing a v2.=0A=
> =0A=
That's true.=0A=
Since this patch set is orthogonal to the bug, IMO the fix shouldn't be par=
t of it.=0A=
=0A=
Thanks,=0A=
Horia=0A=