Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Sascha Hauer <s.hauer@pengutronix.de>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
CC:     "kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH 2/3] crypto: caam: print debug messages at debug level
Thread-Topic: [PATCH 2/3] crypto: caam: print debug messages at debug level
Thread-Index: AQHVDJL8mmT01przhESHS2q17fhpQg==
Date:   Tue, 21 May 2019 14:31:23 +0000
Message-ID: <VI1PR0402MB3485594CF5ECFD6F08AF7FA298070@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <20190517092905.1264-1-s.hauer@pengutronix.de>
 <20190517092905.1264-3-s.hauer@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 740529ca-f60b-4a6d-ab14-08d6ddf90023
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2019 14:31:23.7357
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3407
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 5/17/2019 12:29 PM, Sascha Hauer wrote:=0A=
> The CAAM driver used to put its debug messages inside #ifdef DEBUG and=0A=
> then prints the messages at KERN_ERR level. Replace this with proper=0A=
> functions printing at KERN_DEBUG level. The #ifdef DEBUG gets=0A=
> unnecessary when the right functions are used.=0A=
> =0A=
> This replaces:=0A=
> =0A=
> - print_hex_dump(KERN_ERR ...) inside #ifdef DEBUG with=0A=
>   print_hex_dump_debug(...)=0A=
> - dev_err() inside #ifdef DEBUG with dev_dbg()=0A=
> - printk(KERN_ERR ...) inside #ifdef DEBUG with dev_dbg()=0A=
> =0A=
> Some parts of the driver use these functions already, so it is only=0A=
> consequent to use the debug function consistently.=0A=
> =0A=
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>=0A=
> ---=0A=
>  drivers/crypto/caam/caamalg.c      |  95 ++++++++--------------=0A=
>  drivers/crypto/caam/caamalg_desc.c |  71 ++++------------=0A=
>  drivers/crypto/caam/caamalg_qi.c   |  36 +++------=0A=
>  drivers/crypto/caam/caamhash.c     | 126 +++++++++--------------------=
=0A=
>  drivers/crypto/caam/caamrng.c      |  16 ++--=0A=
>  drivers/crypto/caam/key_gen.c      |  19 ++---=0A=
>  drivers/crypto/caam/sg_sw_sec4.h   |   5 +-=0A=
>  7 files changed, 113 insertions(+), 255 deletions(-)=0A=
> =0A=
> diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.=
c=0A=
> index 007c35cfc670..1395b4860f23 100644=0A=
> --- a/drivers/crypto/caam/caamalg.c=0A=
> +++ b/drivers/crypto/caam/caamalg.c=0A=
> @@ -575,13 +575,11 @@ static int aead_setkey(struct crypto_aead *aead,=0A=
>  	if (crypto_authenc_extractkeys(&keys, key, keylen) !=3D 0)=0A=
>  		goto badkey;=0A=
>  =0A=
> -#ifdef DEBUG=0A=
> -	printk(KERN_ERR "keylen %d enckeylen %d authkeylen %d\n",=0A=
> +	dev_dbg(jrdev, "keylen %d enckeylen %d authkeylen %d\n",=0A=
>  	       keys.authkeylen + keys.enckeylen, keys.enckeylen,=0A=
>  	       keys.authkeylen);=0A=
> -	print_hex_dump(KERN_ERR, "key in @"__stringify(__LINE__)": ",=0A=
> +	print_hex_dump_debug("key in @"__stringify(__LINE__)": ",=0A=
>  		       DUMP_PREFIX_ADDRESS, 16, 4, key, keylen, 1);=0A=
The alignments should probably be taken care of too, even if it adds a bit =
of noise.=0A=
=0A=
Thanks,=0A=
Horia=0A=