Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1398279ybm; Wed, 22 May 2019 23:53:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqwq1kXT/8sTzYva/3DG1FSabz1nU39BU3LtUINFSiQgFXD3EMT531zKD3uLxRLzsgNtN7ly X-Received: by 2002:a17:902:778d:: with SMTP id o13mr37227471pll.275.1558594398462; Wed, 22 May 2019 23:53:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558594398; cv=none; d=google.com; s=arc-20160816; b=WczmJiqCHvHZRkmd/hMSqWn0B4nfORAR2COLLiou3JgRUnGho48EQ3IU7XNkcpVNW6 +Wp4fTQpIcjIqdDTOAcPtW6cEWNNqKsRu98sOodXBT2eXZmmOqhPyL/erKyz8IJZazt+ 5BtAtGXMm+RshrK/WU/D9zBcsfSAk6gKnL5bsHv9vFSvi/Kz88RqkovVkMtcyzYwJwlT GitnSjsMeORwfgs2oE4jj4KKwHT+88HTOsnP3c2fSxFhxAVc1fRc52Un3RGnX8QTU6Tg dO4RE0z2UWihj2aCwKCHPXN0FSGSBQ+8NnQSBrg9v4SFMIVN5zHZbmwHatL+HmLm3aQ/ /oww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jHPCIF9aqwH/aVEN/nI1ttqz24bkV4NTQIPx5bzJLSE=; b=caOC982cye8qQJ//LMIz6tg8q72gi8uEusoShVFQKSNYxLwOug0RANHxbF/c2Pqo6o /r6fpv9L9ts4YC9KZCKNrVePPmhdyup5K9Bgj4tzn6rV5lW4+40I3Nx6d1BEo4NGUFfm 0xPB2t2ZCY9d6nTnStremYrPc0wyXL3VMho58KHU0V9BNgUIyXoMrM/+qEmg4vcOqJOF H2ikzmGynpPuXWkaqgb69uu+mwIzleNSpuSyn/+lC2yvWkEPZm6wLIXKswfAM4hsMNf4 31Q1EqV/618YdFh4Bb+hvLc3CKPqaA3cG/iB88cMXUu5SmCq3hXtNqJSVdHB5ePtEKpE zUXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o28si27942882pgm.183.2019.05.22.23.53.04; Wed, 22 May 2019 23:53:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726237AbfEWGwr (ORCPT + 99 others); Thu, 23 May 2019 02:52:47 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:47814 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725806AbfEWGwr (ORCPT ); Thu, 23 May 2019 02:52:47 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hThao-0001qs-ET; Thu, 23 May 2019 14:52:46 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hThan-0006D9-2p; Thu, 23 May 2019 14:52:45 +0800 Date: Thu, 23 May 2019 14:52:45 +0800 From: Herbert Xu To: Christian Lamparter Cc: linux-crypto@vger.kernel.org, Eric Biggers Subject: Re: [PATCH 1/2] crypto: crypto4xx - fix blocksize for cfb and ofb Message-ID: <20190523065245.x3y6spbez3so3ryv@gondor.apana.org.au> References: <20190518212812.21414-1-chunkeey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190518212812.21414-1-chunkeey@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, May 18, 2019 at 11:28:11PM +0200, Christian Lamparter wrote: > While the hardware consider them to be blockciphers, the > reference implementation defines them as streamciphers. > > Do the right thing and set the blocksize to 1. This > was found by CONFIG_CRYPTO_MANAGER_EXTRA_TESTS. > > This fixes the following issues: > skcipher: blocksize for ofb-aes-ppc4xx (16) doesn't match generic impl (1) > skcipher: blocksize for cfb-aes-ppc4xx (16) doesn't match generic impl (1) > > Cc: Eric Biggers > Cc: stable@vger.kernel.org > Fixes: f2a13e7cba9e ("crypto: crypto4xx - enable AES RFC3686, ECB, CFB and OFB offloads") > Signed-off-by: Christian Lamparter > --- > drivers/crypto/amcc/crypto4xx_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt