Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Iuliana Prodan <iuliana.prodan@nxp.com>
CC:     Aymen Sghaier <aymen.sghaier@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v2 1/2] crypto: caam - fix pkcs1pad(rsa-caam, sha256)
 failure because of invalid input
Thread-Topic: [PATCH v2 1/2] crypto: caam - fix pkcs1pad(rsa-caam, sha256)
 failure because of invalid input
Thread-Index: AQHVES51mI1lYxB850GcRxowCCF+GA==
Date:   Thu, 23 May 2019 10:02:41 +0000
Message-ID: <AM0PR0402MB3476BE4FE08AC135742D262998010@AM0PR0402MB3476.eurprd04.prod.outlook.com>
References: <1557919546-360-1-git-send-email-iuliana.prodan@nxp.com>
 <20190523061202.ic2vgimgzvvm6dzc@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 50572e9b-fb64-4988-b289-08d6df65cbad
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2019 10:02:41.9993
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3457
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 5/23/2019 9:12 AM, Herbert Xu wrote:=0A=
> On Wed, May 15, 2019 at 02:25:45PM +0300, Iuliana Prodan wrote:=0A=
>>=0A=
>> @@ -1058,6 +1105,14 @@ static int __init caam_pkc_init(void)=0A=
>>  		goto out_put_dev;=0A=
>>  	}=0A=
>>  =0A=
>> +	/* allocate zero buffer, used for padding input */=0A=
>> +	zero_buffer =3D kzalloc(CAAM_RSA_MAX_INPUT_SIZE - 1, GFP_DMA |=0A=
>> +			      GFP_KERNEL);=0A=
>> +	if (!zero_buffer) {=0A=
>> +		err =3D -ENOMEM;=0A=
>> +		goto out_put_dev;=0A=
>> +	}=0A=
>> +=0A=
>>  	err =3D crypto_register_akcipher(&caam_rsa);=0A=
>>  	if (err)=0A=
>>  		dev_warn(ctrldev, "%s alg registration failed\n",=0A=
> =0A=
> This patch does not apply on top of the caam patch-series from Horia.=0A=
The patch was considered a fix, and thus developed on top of crypto-2.6.=0A=
I guess you are implicitly asking to resubmit based on cryptodev-2.6, corre=
ct?=0A=
=0A=
> You're also going to leak zero_buffer if crypto_register_akcipher=0A=
> fails.=0A=
> =0A=
When crypto_register_akcipher fails, it merely prints a warning and falls=
=0A=
through (does not immediately return), thus there's no leak.=0A=
=0A=
Thanks,=0A=
Horia=0A=