Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1707837ybm; Thu, 23 May 2019 05:39:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwc6KMU+2Fmojswf9/n7gxDz1FUS7VjVKAEBtEGf8NrWzE86XwTwYzZWkzSvZqie4zLH4ec X-Received: by 2002:a17:902:2e83:: with SMTP id r3mr81694001plb.139.1558615161090; Thu, 23 May 2019 05:39:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558615161; cv=none; d=google.com; s=arc-20160816; b=gtlsMznlmw9Oy4HaC1f2eNZhAZKBbsWVhBqWAeBcAsL7pvY9XnlAwigRZj9TcK8wAm qCoElmmCrb5of8zPEE+5BP4H6+UT7ch2s1fyPsDn3o8vYtyGg8F9RFoetNpDkxKYwpoZ s9e3FgUiV7EB7Tsyugyaa+OMQy+yWbjrdUY7LADr+lZ2vT8tX8hrRKy2/w32FegWVZJ8 ME2U23sPwV/nL2j0R8MJGeAp4ZMn3YcpZOZdu9NiialE6ux2LOaKFkANlCGnqVx5ujN0 x0628CIpSjgaGJDpm+gQ0Ekcznq/uwjJanyPUUiZZRa5rGD+97HZ/zoEsDnpTdgmO0TH Qu8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jrGRrU7rH7n2thvV28DfVPaAEPtrW9caqGKYG6+QI+w=; b=gblvJCmvzhr+Yz+O815K8PMafdrq8qbaGmdQ1XdPb2xpOxWxJGvsx0EtjSKLOJOCR1 jXSXdSy3a2/5WbqqAWzSlIRr6Ao6elcVdcjymDAwtOxk3aIJ9OecUZvC5757PK1lXIxR y1kLktu2nfQM4zdt1GLsk9/b48Mo29N2Tcvb0AnDPOfq/C+POfh/wJeybwrMpT5aYxmD f5w6brcU22tiksV0m4PW8EtuN9UK+0MMdaFaapZpICT3C7vaH3ui87OSk+eKyN21iN6w joHiPaCrrh5W4+ei11ZFydxknOdrK3eegwu+1bwYvDqhSkdB3ZpzawMsVz0+f5LcMMmm CY9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q20si7855163pfn.139.2019.05.23.05.38.58; Thu, 23 May 2019 05:39:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729902AbfEWMiS (ORCPT + 99 others); Thu, 23 May 2019 08:38:18 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:50096 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729762AbfEWMiS (ORCPT ); Thu, 23 May 2019 08:38:18 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hTmzA-0002N7-Jk; Thu, 23 May 2019 20:38:16 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hTmz7-0007Dd-Ln; Thu, 23 May 2019 20:38:13 +0800 Date: Thu, 23 May 2019 20:38:13 +0800 From: Herbert Xu To: Horia Geanta Cc: Iuliana Prodan , Aymen Sghaier , "David S. Miller" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH v2 1/2] crypto: caam - fix pkcs1pad(rsa-caam, sha256) failure because of invalid input Message-ID: <20190523123813.xosynrnsdpqfieqv@gondor.apana.org.au> References: <1557919546-360-1-git-send-email-iuliana.prodan@nxp.com> <20190523061202.ic2vgimgzvvm6dzc@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, May 23, 2019 at 10:02:41AM +0000, Horia Geanta wrote: > > When crypto_register_akcipher fails, it merely prints a warning and falls > through (does not immediately return), thus there's no leak. How can this work? Wouldn't the exit path then unregister a bunch of unregistered algorithms and crash? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt