Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190430162910.16771-1-ard.biesheuvel@linaro.org>
 <20190430162910.16771-6-ard.biesheuvel@linaro.org> <CAL_JsqLioethaQ2ekxyeG1QkCwPQKcE4daDMAJXtWwXOEABmGQ@mail.gmail.com>
 <CAKv+Gu-55A=WCx+9He1rc52KKuQ53fMP8efw6DO+wkfr3K+Rdw@mail.gmail.com>
In-Reply-To: <CAKv+Gu-55A=WCx+9He1rc52KKuQ53fMP8efw6DO+wkfr3K+Rdw@mail.gmail.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Fri, 24 May 2019 08:36:28 -0500
Message-ID: <CAL_JsqLMubawNufJySC-iS0ELwRC4hk+yMNZMVuMD3FbJPQYWw@mail.gmail.com>
Subject: Re: [PATCH 5/5] dt-bindings: add Atmel SHA204A I2C crypto processor
To:     Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc:     "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Joakim Bech <joakim.bech@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Fri, May 24, 2019 at 8:16 AM Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 24 May 2019 at 15:12, Rob Herring <robh+dt@kernel.org> wrote:
> >
> > On Tue, Apr 30, 2019 at 11:29 AM Ard Biesheuvel
> > <ard.biesheuvel@linaro.org> wrote:
> > >
> > > Add a compatible string for the Atmel SHA204A I2C crypto processor.
> > >
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > ---
> > >  Documentation/devicetree/bindings/crypto/atmel-crypto.txt | 13 +++++++++++++
> > >  1 file changed, 13 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/crypto/atmel-crypto.txt b/Documentation/devicetree/bindings/crypto/atmel-crypto.txt
> > > index 6b458bb2440d..a93d4b024d0e 100644
> > > --- a/Documentation/devicetree/bindings/crypto/atmel-crypto.txt
> > > +++ b/Documentation/devicetree/bindings/crypto/atmel-crypto.txt
> > > @@ -79,3 +79,16 @@ atecc508a@c0 {
> > >         compatible = "atmel,atecc508a";
> > >         reg = <0xC0>;
> > >  };
> > > +
> > > +* Symmetric Cryptography (I2C)
> >
> > This doesn't really seem to be related to the rest of the file which
> > are all sub-blocks on SoCs. You could just add this one to
> > trivial-devices.yaml.
> >
> > > +
> > > +Required properties:
> > > +- compatible : must be "atmel,atsha204a".
> > > +- reg: I2C bus address of the device.
> > > +- clock-frequency: must be present in the i2c controller node.
> >
> > That's a property of the controller and doesn't belong here.
> >
>
> Both comments apply equally to the ECC508 above it, which I
> duplicated.

Okay, I only quickly scanned it. The problem for this file will be
when converting to schema, it's generally 1 binding per file.

> Would you like me to move that one into
> trivial-devices.yaml as well? (and drop the clock-freq property)

If you want, but that can be a separate patch.

Rob