Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4017080ybi; Mon, 27 May 2019 09:30:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/RzAhqsy0X3uUME608hrCZZt0BthDOai1qTDEH36375PqC4VkCoI6NsH7mBcRRtjQMbdB X-Received: by 2002:a63:d354:: with SMTP id u20mr77878752pgi.129.1558974644282; Mon, 27 May 2019 09:30:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558974644; cv=none; d=google.com; s=arc-20160816; b=AcUbC3/qugAMiuFTkjo8z7JOI6zA0LrzFkV61v1/umSIjIOh+RkC7D1ewNPQekxI6e UoN9lPZwWc5o/vDGgbnOqSyxedN8Zrl1pHF6wxclYiApn8DkQlcheabl5hFtcZ3CfufD 1aFLQSim5RJxULQHX+IX5+Q/KHYZXJjmxrE3lABHPniaky5UOmU6DEn0SoD+i+kZkSUl As0oTYr1Wk+7YHmo8oyumpp2p+roqvQ0MnUbkICSn8WH1nog6odKEt4CuqEG4Iq8dKoq 4keb3BB1EseIj1efPjqUwjfmdT1R3yGrQ8Lv+ZfOP7aRbSCr7otac5FFLnev7jDBx6Du j6rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=/IpUbrVPJFSCBKW80LlGo9HKXNMiYICi7OMPtUZ/cLY=; b=GmNCVw2jyL/w/ZWTtO1cJaqAAknXLyyttmiSmeKjTXs7Gn0i4x3ZUww081Ffbla2t/ ffE+V8XJzai6IBFX8A8u7eyiJ0fAtjm29KFYOM4OCzyCkc0agUegcT1W4rI8K+poZ6mV Df6VJVxfPJDoIAjHAw4clrq5372rDQkgZl0VfECOK/4yj85vaU/+r8Wx8zqwjoMktkCc L6DuhYlroldDvgG6rYFTxVUuJMUo025wVlPZDXGoeGjCXFyXj6HsDgb7Jh9Fpc1LPQ8d G+8bi17njxZ8ukviWu22Zq20ZpXtcdG4wL0ceK4KOdeE7BnCvw3+pa5pAX1gzSLZPAsO X8SA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=kmawYSKq; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h11si17667234pgq.170.2019.05.27.09.30.29; Mon, 27 May 2019 09:30:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=kmawYSKq; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbfE0Qa1 (ORCPT + 99 others); Mon, 27 May 2019 12:30:27 -0400 Received: from mail-eopbgr140070.outbound.protection.outlook.com ([40.107.14.70]:56153 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726202AbfE0Qa0 (ORCPT ); Mon, 27 May 2019 12:30:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/IpUbrVPJFSCBKW80LlGo9HKXNMiYICi7OMPtUZ/cLY=; b=kmawYSKqS0QM1vSPCP98hqDRozfWvvlJ7Ijg5xfx5tPOp99UolkQpMeCEUffI+Zn/2XTQ35h92S6mcRU8q9h9ixKGoEfIgl4lE8pdgqDMp/tJg/Ijpo3yV7cCwFLPTLlyhxglmgGxUsJbgMKcp9kupf8HeKxnSkm9DWwExQIu58= Received: from VI1PR0402MB3485.eurprd04.prod.outlook.com (52.134.3.153) by VI1PR0402MB3758.eurprd04.prod.outlook.com (52.134.15.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.18; Mon, 27 May 2019 16:30:22 +0000 Received: from VI1PR0402MB3485.eurprd04.prod.outlook.com ([fe80::ccaf:f4a1:704a:e745]) by VI1PR0402MB3485.eurprd04.prod.outlook.com ([fe80::ccaf:f4a1:704a:e745%4]) with mapi id 15.20.1922.021; Mon, 27 May 2019 16:30:22 +0000 From: Horia Geanta To: Iuliana Prodan , Herbert Xu , Aymen Sghaier CC: "David S. Miller" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH v4] crypto: caam - strip input without changing crypto request Thread-Topic: [PATCH v4] crypto: caam - strip input without changing crypto request Thread-Index: AQHVEj+TCpX7zm1be0iJB21tAPCJpA== Date: Mon, 27 May 2019 16:30:22 +0000 Message-ID: References: <1558709189-7237-1-git-send-email-iuliana.prodan@nxp.com> <1558709189-7237-2-git-send-email-iuliana.prodan@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=horia.geanta@nxp.com; x-originating-ip: [212.146.100.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f9b22d44-2937-4198-7af7-08d6e2c09db8 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR0402MB3758; x-ms-traffictypediagnostic: VI1PR0402MB3758: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:923; x-forefront-prvs: 0050CEFE70 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(39860400002)(366004)(376002)(346002)(136003)(189003)(199004)(66476007)(66556008)(25786009)(64756008)(14444005)(66446008)(66946007)(256004)(76116006)(73956011)(2906002)(8936002)(7696005)(99286004)(305945005)(8676002)(7736002)(33656002)(86362001)(102836004)(54906003)(110136005)(6506007)(53546011)(76176011)(81166006)(81156014)(44832011)(26005)(6436002)(446003)(4326008)(6246003)(6116002)(3846002)(74316002)(6636002)(316002)(14454004)(478600001)(186003)(9686003)(66066001)(229853002)(71190400001)(71200400001)(486006)(68736007)(5660300002)(476003)(53936002)(55016002)(52536014)(4744005)(473944003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0402MB3758;H:VI1PR0402MB3485.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 68aY5EARcwUTWvbJjLXa/qWHT4eZnZ4JhZpWheGdFwaOrXFX/dMaZEx2IIXmtoxENdf1fRQuR+Mcmw+NZr0WtASaIEh3Aun+H37b7Zc5FFvLpUejRxW2hnsNSUU+phczIs/GlVwskqp9VBDYMulpfkO/m5b36hpWcHxQHfXCGlt2odXyOFihrNU9ibQhK4aAKHAGxxABjDrHkXYTn7Zt1mVpVS2jlvhAiR+mSuOQwj5veyr5KvLlS9mK5OILmkF4lBwQxZbI3XCJZKO3FddS7WsvVLAj1iPAu8An4/BCaW5Q6Yqmems7chUZKSrc4RBTu8OzEKzUn7JtX8FaQBaseKWENr4rnDEUhA8jeUUVMhH8oulEhYFqceg/Bs/3AqaEjaA32r4Kkuzm5695hmXo283c8qsxenIeEiODZFSRcOc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9b22d44-2937-4198-7af7-08d6e2c09db8 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2019 16:30:22.6405 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: horia.geanta@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3758 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 5/24/2019 5:47 PM, Iuliana Prodan wrote:=0A= > For rsa and pkcs1pad, CAAM expects an input of modulus size.=0A= > For this we strip the leading zeros in case the size is more than modulus= .=0A= > This commit avoids modifying the crypto request while stripping zeros fro= m=0A= > input, to comply with the crypto API requirement. This is done by adding= =0A= > a fixup input pointer and length.=0A= > =0A= > Signed-off-by: Iuliana Prodan =0A= > ---=0A= > Changes since V3:=0A= > - no changes.=0A= Since there were no changes, you should have kept the Reviewed-by tag I pro= vided=0A= for v3.=0A= =0A= Another thing: don't send a patch set with=0A= [PATCH v3 1/2]=0A= [PATCH v4]=0A= =0A= It's confusing:=0A= -patches belonging to a patch set should have the same version / prefix=0A= -makes one think patches are missing (where is 2/2?)=0A= =0A= Thanks,=0A= Horia=0A=